From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52916 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNryn-0004vt-LQ for qemu-devel@nongnu.org; Wed, 01 Dec 2010 14:04:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNrym-0001MM-Dz for qemu-devel@nongnu.org; Wed, 01 Dec 2010 14:04:37 -0500 Received: from mail-ew0-f45.google.com ([209.85.215.45]:58494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNrym-0001M5-9V for qemu-devel@nongnu.org; Wed, 01 Dec 2010 14:04:36 -0500 Received: by ewy10 with SMTP id 10so4103966ewy.4 for ; Wed, 01 Dec 2010 11:04:34 -0800 (PST) Date: Wed, 1 Dec 2010 20:02:52 +0100 From: "Edgar E. Iglesias" Subject: Re: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan() Message-ID: <20101201190252.GC6702@laped.lan> References: <1291116333-21354-1-git-send-email-peter.maydell@linaro.org> <20101201171248.GK24280@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101201171248.GK24280@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: Peter Maydell , qemu-devel@nongnu.org On Wed, Dec 01, 2010 at 09:12:48AM -0800, Nathan Froyd wrote: > On Tue, Nov 30, 2010 at 11:25:33AM +0000, Peter Maydell wrote: > > The softfloat functions float*_is_nan() were badly misnamed, > > because they return true only for quiet NaNs, not for all NaNs. > > Rename them to float*_is_quiet_nan() to more accurately reflect > > what they do. > > > > This change was produced by: > > perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan) > > (with the results manually checked.) > > > > Signed-off-by: Peter Maydell > > Reviewed-by: Nathan Froyd This looks good to me too. Acked-by: Edgar E. Iglesias Cheers