From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47230 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNwBe-00049s-JX
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 18:34:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PNwBd-0006uF-EP
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 18:34:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48399)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PNwBd-0006u8-4f
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 18:34:09 -0500
Date: Wed, 1 Dec 2010 18:56:40 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20101201205640.GB18395@amt.cnet>
References: <20101201164704.729398122@redhat.com>
	<20101201164743.090538903@redhat.com> <4CF682D4.1080200@redhat.com>
	<m3lj49wbjl.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3lj49wbjl.fsf@trasno.mitica>
Subject: [Qemu-devel] Re: [patch 3/3] UHCI: Substate section for migration
 of remote wakeup feature
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Wed, Dec 01, 2010 at 08:14:22PM +0100, Juan Quintela wrote:
> Gerd Hoffmann <kraxel@redhat.com> wrote:
> > On 12/01/10 17:47, Marcelo Tosatti wrote:
> >> Use a subsection to migrate remote wakeup feature only when used by the guest.
> >
> > Yea, right, this must be saved.  But certainly not by the UHCI
> > adapter, it belongs into the usb devices.  Some of them don't save
> > state at all today, which makes it a bit tricky to do this in a way
> > that migration to older versions keeps working at least as long as
> > remote wakeup isn't used ...
> >
> > Juan, any idea?
> 
> Second thought.
> 
> Only to add sections for all devices that don't have one.  But the
> problem is that we have optional subsections, not optional subsections
> (it is not a way to not send a section because no value there).
> 
> Later, Juan.

Which breaks migration for older versions. Which lowers the
applicability of s/r.

Yes, remote_wakeup does not belong to UHCI, but i dont see another
solution. Or break migration upstream and use the hack for vendors.