From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach 'coherency=full' O_DIRECT writes to correctly up_read i_alloc_sem.
Date: Wed, 1 Dec 2010 19:09:33 -0800 [thread overview]
Message-ID: <20101202030932.GE16604@mail.oracle.com> (raw)
In-Reply-To: <4CE9E198.4070709@oracle.com>
On Mon, Nov 22, 2010 at 11:20:56AM +0800, Tristan Ye wrote:
> >yes, it looks more natural and easy. So when you lock i_alloc_sem,
> >just call ocfs2_iocb_set_sem_locked, and when you lock rw_lock,
> >just set the ocfs2_iocb_set_rw_locked. That's it. You don't neet
> >to think about some stuff like coherency or not.
>
> Reasonable.
>
> Joel,
>
> How do you think about it?
I agree with Tao. ocfs2_dio_end_io() doesn't care why the
locks are locked; it just needs to know which ones to release.
Joel
--
Life's Little Instruction Book #20
"Be forgiving of yourself and others."
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-12-02 3:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 8:38 [Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach 'coherency=full' O_DIRECT writes to correctly up_read i_alloc_sem Tristan Ye
2010-11-19 14:34 ` Tao Ma
2010-11-22 2:22 ` Tristan Ye
2010-11-22 2:59 ` Tao Ma
2010-11-22 3:20 ` Tristan Ye
2010-12-02 3:09 ` Joel Becker [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-29 7:54 Tristan Ye
2010-11-29 8:40 ` Tao Ma
2010-11-29 9:04 ` Tristan Ye
2010-11-29 9:21 Tristan Ye
2010-11-30 6:45 ` Tao Ma
2010-11-30 7:03 ` Tristan Ye
2010-11-30 7:06 ` Tristan Ye
2010-12-06 23:24 ` Joel Becker
2010-12-07 1:47 ` Tristan Ye
2010-12-07 6:35 Tristan Ye
2010-12-10 1:45 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202030932.GE16604@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.