From: Wolfram Sang <w.sang@pengutronix.de>
To: Chuanxiao Dong <chuanxiao.dong@intel.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
cjb@laptop.org, arjan@linux.intel.com, alan@linux.intel.com,
akpm@linux-foundation.org, adrian.hunter@nokia.com
Subject: Re: [PATCH v3 2/3]set timeout control reg for such SDHCI host
Date: Thu, 2 Dec 2010 12:53:30 +0100 [thread overview]
Message-ID: <20101202115329.GE3345@pengutronix.de> (raw)
In-Reply-To: <20101202112613.GC10358@intel.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote:
> + if (host->quirks & SDHCI_QUIRK_FORCE_ERASE_SINGLE) {
> + /* Set the timeout to be the maximum value */
> + if (cmd->erase_timeout)
> + sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL);
> + }
> +
> sdhci_writew(host, SDHCI_MAKE_CMD(cmd->opcode, flags), SDHCI_COMMAND);
Hmm, this looks like another argument for Philip's idea to always use
the maximum timeout value and skip the quirks related to it?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-12-02 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 11:26 [PATCH v3 2/3]set timeout control reg for such SDHCI host Chuanxiao Dong
2010-12-02 11:53 ` Wolfram Sang [this message]
2010-12-03 2:38 ` Dong, Chuanxiao
2010-12-04 21:33 ` Wolfram Sang
2010-12-05 11:48 ` Dong, Chuanxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202115329.GE3345@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.