Re: [PATCH 1/1] sanity.bbclass: add check for creation of long filenames

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 02 December 2010 14:16:35 Gary Thomas wrote:
> On 12/02/2010 07:13 AM, Paul Eggleton wrote:
> > On Thursday 02 December 2010 12:21:06 Gary Thomas wrote:
> >> Is this information cached?  It's seems quite the burden
> >> to have to create/remove ~400 files each time on startup.
> >
> > I'm not sure what you mean - this check (well, all sanity checks) should only occur once per invocation of bitbake.
> 
> Precisely what I mean.  The computed max length won't change
> unless you move the tmp or sstate-cache directories, so recomputing
> it every time you run bitbake is a horrible overhead.

It would also change if the filesystem where TMPDIR or SSTATE_DIR is stored changes, which could occur without the path itself changing, e.g. someone switches over their home directory to be encrypted. It would be possible to cache this check based on the filesystem and path, but is it really worth it given that we would have to read the disk to check if these had changed anyway? I do understand we have to be careful about items we add to the sanity checks, but in this instance we're talking about writing one file - something that should take a matter of milliseconds.

Cheers,
Paul