From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org
Subject: Re: [PATCH] PCI: Disable ASPM if BIOS asks us to
Date: Thu, 2 Dec 2010 22:31:35 +0000 [thread overview]
Message-ID: <20101202223135.GA12652@srcf.ucam.org> (raw)
In-Reply-To: <201012022324.31760.rjw@sisk.pl>
On Thu, Dec 02, 2010 at 11:24:31PM +0100, Rafael J. Wysocki wrote:
> > + if (!aspm_force) {
> > aspm_disabled = 1;
> > + if (clear)
> > + aspm_clear_state = clear;
>
> Well, is the if(clear) really necessary?
If the FADT disables ASPM, and then we fail to get the control bits,
we'd call this twice and turn off aspm_clear_state.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-02 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 21:55 [PATCH] PCI: Disable ASPM if BIOS asks us to Matthew Garrett
2010-12-02 22:24 ` Rafael J. Wysocki
2010-12-02 22:31 ` Matthew Garrett [this message]
2010-12-02 22:51 ` Rafael J. Wysocki
2010-12-02 22:55 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202223135.GA12652@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.