Re: Bug in 8250.c - uninitialized FIFOs

[Greg KH <greg@kroah.com>]

On Fri, Dec 03, 2010 at 06:56:16PM +0100, Ondřej Pužman wrote:
> Here is the patch to correct the bug created against 2.6.36.1:
> 
> diff -Naur a/drivers/serial/8250.c b/drivers/serial/8250.c
> --- a/drivers/serial/8250.c     2010-11-22 20:03:49.000000000 +0100
> +++ b/drivers/serial/8250.c     2010-12-03 18:32:54.000000000 +0100
> @@ -1952,6 +1952,8 @@
>        unsigned char lsr, iir;
>        int retval;
> 
> +       up->port.fifosize = uart_config[up->port.type].fifo_size;
> +       up->tx_loadsz = uart_config[up->port.type].tx_loadsz;
>        up->capabilities = uart_config[up->port.type].flags;
>        up->mcr = 0;
> 
> 
> The patch should work on most 2.6.x kernels.
> I hope that someone will be able to put that in the official kernel tree.

I would like to include it, but I need it in a form I can apply it in.
Your email client turned the tabs to spaces, and I need a
"Signed-off-by:" line in order to be able to apply it.  Take a look at
the file, Documentation/SubmittingPatches for details about this.

Care to fix this and resend it so I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html