All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Xenofon Foukas <foukas.xenofon@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] Fix coding style issues in drivers.c
Date: Sat, 4 Dec 2010 00:30:43 +0200	[thread overview]
Message-ID: <20101203223043.GA28174@core2.telecom.by> (raw)
In-Reply-To: <1291411877-15579-1-git-send-email-foukas.xenofon@gmail.com>

On Fri, Dec 03, 2010 at 11:31:17PM +0200, Xenofon Foukas wrote:
> This patch fixes line over 80 characters warning issues found
> in file drivers.c
> Signed-off-by: Xenofon Foukas <foukas.xenofon@gmail.com>

string literals shouldn't be broken because people grep for them.

> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -118,7 +118,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	for (driv = comedi_drivers; driv; driv = driv->next) {
>  		if (!try_module_get(driv->module)) {
>  			printk
> -			    (KERN_INFO "comedi: failed to increment module count, skipping\n");
> +			     (KERN_INFO "comedi: failed to increment "
> +						"module count, skipping\n");
>  			continue;
>  		}
>  		if (driv->num_names) {

  parent reply	other threads:[~2010-12-03 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 21:31 [PATCH] Fix coding style issues in drivers.c Xenofon Foukas
2010-12-03 21:38 ` Greg KH
2010-12-03 22:30 ` Alexey Dobriyan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-03 22:17 Xenofon Foukas
2010-12-03 21:27 Xenofon Foukas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101203223043.GA28174@core2.telecom.by \
    --to=adobriyan@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=foukas.xenofon@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.