From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 4 Dec 2010 05:34:55 -0500
Subject: [U-Boot] [RFC 1/3] tools/env: Default to the config specified
	in FW_CONFIG_FILE
In-Reply-To: <1291436933-26861-2-git-send-email-steve@sakoman.com>
References: <1291436933-26861-1-git-send-email-steve@sakoman.com>
	<1291436933-26861-2-git-send-email-steve@sakoman.com>
Message-ID: <201012040534.57622.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, December 03, 2010 23:28:51 Steve Sakoman wrote:
> +	if (!config_file || !strlen(config_file)) {

strlen is a bad bad idea.  if you only want to see if it's non-empty, check 
the first byte.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101204/a2a72569/attachment.pgp