From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sun, 05 Dec 2010 13:23:14 +0100
Subject: [U-Boot] [PATCH] Enable garbage collection of unused input
	sections.
In-Reply-To: <1291545952-26761-2-git-send-email-luigi.mantellini@idf-hit.com>
References: <1291545952-26761-1-git-send-email-luigi.mantellini@idf-hit.com>
	<1291545952-26761-2-git-send-email-luigi.mantellini@idf-hit.com>
Message-ID: <20101205122314.34EB0351@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Luigi 'Comio' Mantellini,

In message <1291545952-26761-2-git-send-email-luigi.mantellini@idf-hit.com> you wrote:
> When available, enable the CC -ffunction-sections/-fdata-sections options and
> the LD --gc-sections in order to isolate and remove from final executable the
> unused functions.
...

> ---
>  config.mk |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)

Why do you ignore my previous review comments?

You cannot simply turn this feature on globally for all boards.  You
will have to make appropriate adjustments more or less everywhere:

- some architectures already have these options set, so these should
  be removed from the architecture / board specific config files

- other architectures have this NOT set, and they need adjustments to
  the respective inker scripts.

As is, your patch breaks a zillion of boards.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To the systems programmer,  users  and  applications  serve  only  to
provide a test load.