Re: [PATCH] fix debugfs output for flex_bg bitmap offsets

[Ted Ts'o <tytso@mit.edu>]

On Fri, Nov 26, 2010 at 05:33:27PM -0700, Andreas Dilger wrote:
> On 2010-11-25, at 12:09, Andreas Dilger wrote:
> > ...with patch this time...
> 
> Attached is an updated patch that makes the output a bit more
> verbose (to avoid line wraps) and doesn't fail the m_raid_opts test
> (which complains when "(+0)" is printed for each inode table).

Every time you write code of the form:

      if (block >= first_block + !!itable && ...)

Gcc kills a kitten.  Please, think of the kittens....

I rewrote that code as follows:  

	if ((block >= first_block) && (block <= last_block)) {
		if (itable && block == first_block)
			return;
		printf(" (+%u)", (unsigned)(block - first_block));
	} else if ...


I also changed the output to use "(bg #16 + 4)" since I think it's a
bit easier to understand than "(grp 16+4)".

Otherwise, I've added it to the e2fsprogs maint branch, thanks.

	   	      	    		  - Ted