From: Stephen Hemminger <shemminger@vyatta.com>
To: leitao@linux.vnet.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: add the correct LRO status at dev->features
Date: Mon, 6 Dec 2010 08:48:24 -0800 [thread overview]
Message-ID: <20101206084824.637d6b29@nehalam> (raw)
In-Reply-To: <1291653582-14177-1-git-send-email-leitao@linux.vnet.ibm.com>
On Mon, 6 Dec 2010 14:39:42 -0200
leitao@linux.vnet.ibm.com wrote:
> Currently ehea is not setting NETIF_F_LRO, and it is not providing
> a callback for get_flags on ethtool. This patch fixes it.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
More importantly, ehea does not support set_flags to disable LRO.
I will be more blunt. Any device that supports LRO and does
not have the necessary interface to disable it is broken and should
not be used.
--
next prev parent reply other threads:[~2010-12-06 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 16:39 [PATCH] ehea: add the correct LRO status at dev->features leitao
2010-12-06 16:48 ` Stephen Hemminger [this message]
2010-12-06 16:57 ` Breno Leitao
2010-12-06 17:10 ` [RFC] mark devices with broken LRO implementation Stephen Hemminger
2010-12-06 17:18 ` Olof Johansson
2010-12-06 17:28 ` David Miller
2010-12-06 17:58 ` Stephen Hemminger
2010-12-06 17:33 ` [PATCH] ehea: add the correct LRO status at dev->features David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206084824.637d6b29@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.