From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] KVM: MMU: rename 'no_apf' to 'prefault'
Date: Mon, 6 Dec 2010 11:32:08 +0200 [thread overview]
Message-ID: <20101206093208.GA15610@redhat.com> (raw)
In-Reply-To: <20101203203055.GB26281@amt.cnet>
On Fri, Dec 03, 2010 at 06:30:55PM -0200, Marcelo Tosatti wrote:
> On Thu, Dec 02, 2010 at 05:44:43PM +0800, Xiao Guangrong wrote:
> > It's the speculative path if 'no_apf = 1' and we will specially handle this
> > speculative path in the later patch, so 'prefault' is better to fit the sense
> >
> > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> > ---
> > arch/x86/include/asm/kvm_host.h | 3 ++-
> > arch/x86/kvm/mmu.c | 18 +++++++++---------
> > arch/x86/kvm/paging_tmpl.h | 4 ++--
> > 3 files changed, 13 insertions(+), 12 deletions(-)
>
> Looks good to me. Avi, Gleb?
Looks mostly OK to me too. Third patch check only cr3 but cr4 & efer can
affect paging too, but since page fault is not injected anyway in case
of an error and for most guests cr4 & efer shouldn't change frequently I
guess this is OK.
--
Gleb.
prev parent reply other threads:[~2010-12-06 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 9:44 [PATCH v4 1/3] KVM: MMU: rename 'no_apf' to 'prefault' Xiao Guangrong
2010-12-02 9:45 ` [PATCH v4 2/3] KVM: MMU: fix accessed bit set on prefault path Xiao Guangrong
2010-12-02 9:46 ` [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu Xiao Guangrong
2010-12-06 9:48 ` Avi Kivity
2010-12-06 10:22 ` Xiao Guangrong
2010-12-06 13:17 ` Avi Kivity
2010-12-02 9:51 ` Xiao Guangrong
2010-12-03 20:30 ` [PATCH v4 1/3] KVM: MMU: rename 'no_apf' to 'prefault' Marcelo Tosatti
2010-12-06 9:32 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206093208.GA15610@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.