From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kroah.org ([198.145.64.141]:60924 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693Ab0LFP6X (ORCPT ); Mon, 6 Dec 2010 10:58:23 -0500 Date: Mon, 6 Dec 2010 07:58:26 -0800 From: Greg KH Subject: Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents Message-ID: <20101206155826.GD23214@kroah.com> References: <1291639071-10862-1-git-send-email-pkondeti@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291639071-10862-1-git-send-email-pkondeti@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavankumar Kondeti Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: > OTG specification mandates no silent failures and all errors should > be reported to the user. The spec itself does not give the exact > error description. But recommends the error message to be self > explanatory. Provide otg_notify_error() utility for USB core and > OTG driver to send the error codes to user space. All the error > code values are described in include/linux/usb/ch9.h. The user space > application can listen to netlink socket and parse the buffer for > "MODULE=OTG" and "ERROR=n", where 'n' contains the error code. How are you going to listen to the netlink socket that is already grabbed by libudev? Please, if you really want to do this, create your own netlink socket, don't create new uevent messages that will just confused the existing tools out there, that's ripe for big problems. thanks, greg k-h