From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Joe Perches <joe@perches.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address
Date: Mon, 6 Dec 2010 16:11:27 -0200 [thread overview]
Message-ID: <20101206181127.GB883@vigoh> (raw)
In-Reply-To: <a33a0b00eeb29713a08d91156cbb2d816176f990.1291419007.git.joe@perches.com>
Hi Joe,
* Joe Perches <joe@perches.com> [2010-12-03 18:33:03 -0800]:
> Bluetooth output the MAC address in reverse order.
> Bluetooth memory order: 00 01 02 03 04 05 is output "05:04:03:02:01:00".
>
> This can save overall text when bluetooth is compiled in.
>
> Bluetooth currently uses a very slightly unsafe local function (batostr)
> to output these formatted addresses.
>
> Adding %pMbt allows the batostr function to be removed.
>
> For x86:
>
> $ size lib/vsprintf*.o*
> text data bss dec hex filename
> 8189 0 2 8191 1fff lib/vsprintf.o.defconfig.new
> 8150 0 2 8152 1fd8 lib/vsprintf.o.defconfig.old
> 18633 56 3936 22625 5861 lib/vsprintf.o.allyesconfig.new
> 18571 56 3920 22547 5813 lib/vsprintf.o.allyesconfig.old
>
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good to me.
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2010-12-06 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 2:33 [PATCH 0/2] Add and use vsprintf extension %pMbt for bluetooth macs Joe Perches
2010-12-04 2:33 ` Joe Perches
2010-12-04 2:33 ` [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address Joe Perches
2010-12-04 11:03 ` Michał Mirosław
2010-12-04 17:48 ` Joe Perches
2010-12-06 18:11 ` Gustavo F. Padovan [this message]
2010-12-04 2:33 ` [PATCH 2/2] bluetooth: Use printf extension %pMbt Joe Perches
2010-12-06 18:15 ` Gustavo F. Padovan
2010-12-06 18:50 ` Joe Perches
2010-12-06 20:07 ` Gustavo F. Padovan
2010-12-06 20:07 ` Gustavo F. Padovan
2012-05-09 9:01 ` [PATCH 0/2] Add and use vsprintf extension %pMbt for bluetooth macs Andrei Emeltchenko
2012-05-11 23:21 ` Joe Perches
2012-05-25 14:32 ` [RFC] vsprintf: Add %pMR for Bluetooth MAC address andrei.emeltchenko.news
2012-05-25 14:37 ` Gustavo Padovan
2012-05-25 15:07 ` Joe Perches
2012-05-28 9:00 ` [PATCHv2] " Andrei Emeltchenko
2012-05-28 10:01 ` Andy Shevchenko
2012-05-28 10:20 ` Andrei Emeltchenko
2012-05-28 13:05 ` [PATCHv3] " Andrei Emeltchenko
2012-06-05 11:57 ` Andrei Emeltchenko
2012-06-20 10:44 ` [PATCH] Docs: printk-formats: add description for %pMR Andrei Emeltchenko
2012-06-20 21:19 ` Andrew Morton
2012-06-21 7:08 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206181127.GB883@vigoh \
--to=padovan@profusion.mobi \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.