From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: sdparm
Date: Mon, 6 Dec 2010 21:05:10 +0100 [thread overview]
Message-ID: <20101206210510.5ef8ca45@surf> (raw)
In-Reply-To: <4CFCC1D9.8070209@visionsystems.de>
Hello Yegor,
On Mon, 06 Dec 2010 11:58:33 +0100
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:
> Index: b/package/sdparm/Config.in
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ b/package/sdparm/Config.in 2010-12-06 11:14:41.000000000
> +0100 @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_SDPARM
> + bool "sdparm"
> + help
> + Utility to accesses SCSI device parameters.
We generally put the URL of the project here in the help text.
> Index: b/package/sdparm/sdparm.mk
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ b/package/sdparm/sdparm.mk 2010-12-06 08:33:16.000000000
> +0100 @@ -0,0 +1,7 @@
> +SDPARM_VERSION = 1.06
> +SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
> +SDPARM_SITE = http://sg.danny.cz/sg/p/
> +SDPARM_INSTALL_STAGING = NO
> +SDPARM_INSTALL_TARGET = YES
You can get rid of those last two lines, they are the default behaviour.
Once you have fixed those two minors comment, you get my:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Peter: it builds fine here with a minimal Buildroot toolchain (no
largefile, no IPv6, no locale, etc.).
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-12-06 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 10:58 [Buildroot] [PATCH] New package: sdparm Yegor Yefremov
2010-12-06 20:05 ` Thomas Petazzoni [this message]
2010-12-07 9:07 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206210510.5ef8ca45@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.