All of lore.kernel.org
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Problem with sram size on OMAP1611 (OSK)
Date: Mon, 6 Dec 2010 16:18:31 -0800	[thread overview]
Message-ID: <20101207001831.GX8345@atomide.com> (raw)
In-Reply-To: <4CE73921.6030908@am.sony.com>

Hi,

* Tim Bird <tim.bird@am.sony.com> [101119 18:48]:
> Santosh,
> 
> I just tried the latest kernel (well, v2.6.36), and found a problem
> that bisected to the following commit:
> 
> commit e546f21b4b7af012d9f18edad6237339adfeb681
> Author: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Date:   Fri Sep 24 07:19:49 2010 +0100
> 
>     ARM: 6408/1: omap: Map only available sram memory
> 
> I am testing Linux on an OSK board (with an OMAP1611),
> and the above commmit causes the machine to hang.
> I isolated the problem to the sram length.  The commit
> above changes it to a value detected in omap_detect_sram(),
> but when this value is used, my OSK hangs on boot.
> 
> Below is the hack I used to work around this.  I'm not sure
> what the problem is, but I'd be happy to provide more information
> or try other things, to fix support for omap1611 in mainline.
> I tried putting the 1024 * 1024 value into omap_detect_sram(),
> with no luck.  There's some additional processing there which
> might alter the value.  Or perhaps the current value there
> for omap_sram_size on a 1611 is just wrong.
> 
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index 10b3b4c..d4ba4fa 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -236,6 +236,8 @@ void __init omap_map_sram(void)
>         base = ROUND_DOWN(base, PAGE_SIZE);
>         omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
>         omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size, PAGE_SIZE);
> +       if (cpu_is_omap1611())
> +               omap_sram_io_desc[0].length = 1024 * 1024;
>         iotable_init(omap_sram_io_desc, ARRAY_SIZE(omap_sram_io_desc));
> 
>         printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size: 0x%lx\n",

I'm not seeing this on my OSK, can you please check if this still
happening with v2.6.37-rc4?

Regards,

Tony

  reply	other threads:[~2010-12-07  0:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20  2:57 Problem with sram size on OMAP1611 (OSK) Tim Bird
2010-12-07  0:18 ` Tony Lindgren [this message]
2010-12-07  6:20   ` Santosh Shilimkar
2010-12-08  0:56   ` Kevin Hilman
2010-12-09 18:18     ` Tim Bird
2010-12-10  0:31       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101207001831.GX8345@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.