From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/3] Ocfs2: Using macro to set/clear *FILLED* flags in info handler.
Date: Mon, 6 Dec 2010 17:04:24 -0800 [thread overview]
Message-ID: <20101207010424.GL16687@mail.oracle.com> (raw)
In-Reply-To: <1289902422-3315-2-git-send-email-tristan.ye@oracle.com>
On Tue, Nov 16, 2010 at 06:13:40PM +0800, Tristan Ye wrote:
> @@ -139,7 +155,8 @@ int ocfs2_info_handle_blocksize(struct inode *inode,
> goto bail;
>
> oib.ib_blocksize = inode->i_sb->s_blocksize;
> - oib.ib_req.ir_flags |= OCFS2_INFO_FL_FILLED;
> +
> + o2info_set_request_filled(oib);
There's no need to add the extra line of whitespace for all of
these. They're quite readable.
Joel
--
To spot the expert, pick the one who predicts the job will take the
longest and cost the most.
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-12-07 1:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 10:13 [Ocfs2-devel] [PATCH 0/3] Ocfs2: Adding new codes 'OCFS2_INFO_FREEINODE' and 'OCFS2_INFO_FREEFRAG' for o2info ioctl V2 Tristan Ye
2010-11-16 10:13 ` [Ocfs2-devel] [PATCH 1/3] Ocfs2: Using macro to set/clear *FILLED* flags in info handler Tristan Ye
2010-12-07 1:04 ` Joel Becker [this message]
2010-11-16 10:13 ` [Ocfs2-devel] [PATCH 2/3] Ocfs2: Add a new code 'OCFS2_INFO_FREEINODE' for o2info ioctl Tristan Ye
2010-12-07 1:07 ` Joel Becker
2010-12-07 1:46 ` Tristan Ye
2010-11-16 10:13 ` [Ocfs2-devel] [PATCH 3/3] Ocfs2: Add a new code 'OCFS2_INFO_FREEFRAG' " Tristan Ye
2010-12-07 1:11 ` Joel Becker
2010-12-07 1:45 ` Tristan Ye
2010-12-07 3:36 ` Joel Becker
-- strict thread matches above, loose matches on Subject: below --
2011-01-30 6:25 [Ocfs2-devel] [PATCH 0/3] Ocfs2: Adding new codes 'OCFS2_INFO_FREEINODE' and 'OCFS2_INFO_FREEFRAG' for o2info ioctl V2 Tristan Ye
2011-01-30 6:25 ` [Ocfs2-devel] [PATCH 1/3] Ocfs2: Using macro to set/clear *FILLED* flags in info handler Tristan Ye
2011-01-31 22:15 ` Mark Fasheh
2011-02-01 1:10 ` Joel Becker
2011-02-01 3:06 ` Mark Fasheh
2011-02-01 6:01 ` Joel Becker
2011-02-01 7:53 ` Tristan Ye
2011-02-01 17:37 ` Mark Fasheh
2011-02-01 7:48 ` Tristan Ye
2011-02-20 12:08 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207010424.GL16687@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.