From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dave Airlie <airlied@redhat.com>
Cc: airlied@linux.ie, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, konrad@kernel.org,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [RFC PATCH] Utilize the PCI API in the AGP framework.
Date: Mon, 6 Dec 2010 21:12:27 -0500 [thread overview]
Message-ID: <20101207021227.GA31774@dumpdata.com> (raw)
In-Reply-To: <1291684609.8232.8.camel@clockmaker-el6>
> Okay reading that I'm not sure you've started at the right end.
I actually have all of those patches ready but figured I would start
from the AGP side..
>
> I just read 601341, and it concerns nouveau, which shouldn't on the hw
> described be touching AGP at all. Its a PCIE machine, so the DRM/TTM
> code won't use any of the AGP paths.
I think most of them do touch PCIe cards. I swore that there were
some AGP users out there, maybe they aren't on those bugs - let me search
my mail archive. Maybe it just me who still uses AGP...
>
> Now if we have fixes for TTM/nouveau/radeon that make it work under Xen
> then that is a whole different story, however these patches are not
> those.
Nope. I just posted them: https://lkml.org/lkml/2010/12/6/516
>
> I'd suggest you reverse the priority, of the comment
>
> a) Fix the GART/AGP backend (so drivers/char/agp/*.c) so they use the
> PCI API.
> Only the i915 and higher are using the PCI API and I've some of the older
> boxes with i860 so can actually test it.
> b) Fix the TTM to use the DMA API.
> c) Lastly, get rid of _PAGE_IOMAP so we don't have to depend on radeon/nouveau/etc
> to set the proper _PAGE_IOMAP on the PFNs/BARs..
>
> to do c, then b, and finally figure out if anyone cares about a, unless there is a major dependency in the code that requires this ordering.
There is a patch for c) that is nice and simple:
http://git.kernel.org/?p=linux/kernel/git/konrad/xen.git;a=commit;h=f5d630621f6616a8a14438c047332742e77c0739
but we are working on making that obsolete by .. well I can go in details
but it still is just on pieces of paper.
>
> Dave.
next prev parent reply other threads:[~2010-12-07 2:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 23:24 [RFC PATCH] Utilize the PCI API in the AGP framework Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 01/23] agp: Add bridge argument to [free|alloc]_gatt_pages macro Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 02/23] agp: Add dma_addr array in struct agp_memory Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 03/23] agp: Introduce two new macros: _agp_[alloc|free]_page Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 04/23] agp: Make agp_generic_[alloc|destroy]_pages use the _agp_[alloc|free]_page macro Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 05/23] agp: Make agp_generic_[alloc|destroy]_page use " Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 06/23] agp/ali: Use the dma_addr instead of page_to_phys for m1541_[alloc|destroy]_page Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 07/23] agp/nvidia: Use the dma_addr[] instead of page_to_phys when inserting Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 08/23] agp/amd64: Use the dma_addr[] and gatt_bus_addr instead of [page|virt]_to_phys respectivly Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 09/23] agp/amd-k7: Utilize the PCI API for creating/inserting pages Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 10/23] ati/agp: " Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 11/23] agp/serverworks: Utilize the PCI API for allocating/inserting pages Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 12/23] agp/intel-gtt: Utilize the PCI DMA for i8xxx, Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 13/23] ia64/agp/zx1: Use PCI API for inserting pages in HP's ZX1 AGP device Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 14/23] ia64/agp/i460: Use PCI API for inserting pages in DIG (non-VT-d) platforms Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 15/23] agp: Make agp_generic_insert_memory use the mem->dma_addr[i] Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 16/23] agp: save the size of GATT table Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 17/23] agp: Make agp_generic_[create|free]_gatt_table be aware of PCI API Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 18/23] agp/x86: Make agp_generic_* use " Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 19/23] ia64/sgi: fix compile error Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 20/23] ia64: Add DMA_ERROR_CODE define Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 21/23] agp/sgi: Use PCI API for inserting/creating pages on SGI Altix Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 22/23] ia64/agp: Make agp_generic_* use PCI API Konrad Rzeszutek Wilk
2010-12-06 23:24 ` [PATCH 23/23] agp/generic: Set the dma_addr[i] to DMA_ERROR_CODE Konrad Rzeszutek Wilk
2010-12-07 0:02 ` [RFC PATCH] Utilize the PCI API in the AGP framework Dave Airlie
2010-12-07 0:48 ` Konrad Rzeszutek Wilk
2010-12-07 1:16 ` Dave Airlie
2010-12-07 2:12 ` Konrad Rzeszutek Wilk [this message]
2010-12-08 16:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207021227.GA31774@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.