From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/2] ext2: speed up file creates by optimizing rec_len functions
Date: Tue, 7 Dec 2010 13:07:08 -0800 [thread overview]
Message-ID: <20101207130708.71c894e9.akpm@linux-foundation.org> (raw)
In-Reply-To: <4CFE7409.9090609@redhat.com>
On Tue, 07 Dec 2010 11:51:05 -0600
Eric Sandeen <sandeen@redhat.com> wrote:
> The addition of 64k block capability in the rec_len_from_disk
> and rec_len_to_disk functions added a bit of math overhead which
> slows down file create workloads needlessly when the architecture
> cannot even support 64k blocks, thanks to page size limits.
>
> The directory entry checking can also be optimized a bit
> by sprinkling in some unlikely() conditions to move the
> error handling out of line.
>
> bonnie++ sequential file creates on a 512MB ramdisk speeds up
> from about 2200/s to about 2500/s, about a 14% improvement.
>
hrm, that's an improbably-large sounding improvement from eliminating
just a few test-n-branches from a pretty heavyweight operation.
next prev parent reply other threads:[~2010-12-07 21:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 17:47 [PATCH 0/2] ext2, ext3: speed up file create workloads Eric Sandeen
2010-12-07 17:51 ` [PATCH 1/2] ext2: speed up file creates by optimizing rec_len functions Eric Sandeen
2010-12-07 21:07 ` Andrew Morton [this message]
2010-12-07 21:22 ` Eric Sandeen
2010-12-07 21:33 ` Andrew Morton
2010-12-07 21:36 ` Eric Sandeen
2010-12-08 19:01 ` Andreas Dilger
2010-12-08 21:07 ` Eric Sandeen
2010-12-08 21:44 ` Andreas Dilger
2010-12-09 1:06 ` Ric Wheeler
2010-12-10 17:55 ` Ted Ts'o
2010-12-10 18:05 ` Ric Wheeler
2010-12-10 23:40 ` Andreas Dilger
2010-12-11 0:24 ` Eric Sandeen
2010-12-09 2:13 ` Eric Sandeen
2010-12-07 17:55 ` [PATCH 2/2] ext3: " Eric Sandeen
2011-01-06 14:47 ` [PATCH 0/2] ext2, ext3: speed up file create workloads Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207130708.71c894e9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.