From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC][PATCH] input: Introduce device information ioctl Date: Tue, 7 Dec 2010 13:55:08 +0100 Message-ID: <201012071355.08714.arnd@arndb.de> References: <1291706726-8835-1-git-send-email-rydberg@euromail.se> <201012071344.01173.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.10]:65231 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091Ab0LGMzR (ORCPT ); Tue, 7 Dec 2010 07:55:17 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Kay Sievers Cc: Dmitry Torokhov , Henrik Rydberg , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ping Cheng , Chris Bagwell On Tuesday 07 December 2010, Kay Sievers wrote: > >> Oh, how does that work? With the ioctl call, userspace has to supply > >> the size it expects to be returned from the kernel. How does the > >> kernel otherwise know how much it is allowed to copy to the user? > > > > The ioctl command number itself is calculated from the size of the > > data that gets passed: > > > > #define EVIOCGDEVINFO _IOR('E', 0x09, struct input_devinfo) > > > > If struct input_devinfo ever changes (which it can, but should not), > > the command changes as well. > > So unlike statet, it's not extensible, and this struct and this ioctl > can never change? Exactly. We have plenty of unused ioctl numbers free though. Arnd