From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "ext Olaya, Margarita" <magi.olaya@ti.com>,
alsa-devel@alsa-project.org,
ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: omap: Stop DMA re enabling in self linkage mode
Date: Tue, 7 Dec 2010 18:00:42 +0200 [thread overview]
Message-ID: <20101207180042.76e2d122.jhnikula@gmail.com> (raw)
In-Reply-To: <201012071638.36075.peter.ujfalusi@nokia.com>
On Tue, 7 Dec 2010 16:38:35 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> If this could happen, than IMHO it has to be handled by the omap_stop_dma, since
> other drivers could be hit by the same problem (there might be ERRATA for it
> already for OMAP4).
>
I agree with Peter that all DMA stopping related workarounds should be
in omap_stop_dma. I'd expect that DMA is stopped when returning
from there. Commit 9da65a9 was dealing with similar issue so probably
this looping should be implemented somewhere around those lines reading
& clearing the _CCR_EN bit?
--
Jarkko
prev parent reply other threads:[~2010-12-07 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH 2/2] ASoC: omap: Stop DMA re enabling in self linkage mode Olaya, Margarita
2010-12-06 22:47 ` Mark Brown
2010-12-07 9:17 ` Peter Ujfalusi
2010-12-07 14:05 ` Mark Brown
2010-12-07 14:38 ` Peter Ujfalusi
2010-12-07 14:43 ` Mark Brown
2010-12-07 15:17 ` Liam Girdwood
2010-12-07 16:00 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207180042.76e2d122.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.