From: "John W. Linville" <linville@tuxdriver.com>
To: Javier Cardona <javier@cozybit.com>
Cc: Steve Derosier <steve@cozybit.com>,
devel@lists.open80211s.org, linux-wireless@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 2/3] ath5k: Prevent mesh interfaces from being counted as ad-hoc
Date: Tue, 7 Dec 2010 15:58:30 -0500 [thread overview]
Message-ID: <20101207205829.GL2700@tuxdriver.com> (raw)
In-Reply-To: <1291169919-3867-3-git-send-email-javier@cozybit.com>
Missing Signed-off-by...
On Tue, Nov 30, 2010 at 06:18:38PM -0800, Javier Cardona wrote:
> This results in an erroneus num_adhoc_vifs count, as the this counter
> was incremented but not decremented for mesh interfaces.
> ---
> drivers/net/wireless/ath/ath5k/base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 73c7118..44f3050 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -2847,7 +2847,7 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
> sc->bslot[avf->bslot] = vif;
> if (avf->opmode == NL80211_IFTYPE_AP)
> sc->num_ap_vifs++;
> - else
> + else if (avf->opmode == NL80211_IFTYPE_ADHOC)
> sc->num_adhoc_vifs++;
> }
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-07 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 2:18 ath5k: Fixes for mesh operation Javier Cardona
2010-12-01 2:18 ` [PATCH 1/3] ath5k: Fix beaconing in mesh mode Javier Cardona
2010-12-01 13:16 ` Bob Copeland
2010-12-01 18:23 ` Javier Cardona
2010-12-02 1:16 ` Bruno Randolf
2010-12-07 20:58 ` John W. Linville
2010-12-07 21:35 ` Javier Cardona
2010-12-01 2:18 ` [PATCH 2/3] ath5k: Prevent mesh interfaces from being counted as ad-hoc Javier Cardona
2010-12-07 20:58 ` John W. Linville [this message]
2010-12-07 21:36 ` Javier Cardona
2010-12-01 2:18 ` [PATCH 3/3] ath5k: Put the right tsf value in mesh beacons Javier Cardona
2010-12-07 20:57 ` John W. Linville
2010-12-07 21:37 ` Javier Cardona
2010-12-07 19:12 ` ath5k: Fixes for mesh operation Javier Cardona
2010-12-07 20:57 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207205829.GL2700@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=steve@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.