All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Jeff Lance <j-lance1@ti.com>
Subject: Re: [PATCH 1/2] matrix-gui: updating SRC rev to pick up new	platforms and matrix code enhancements
Date: Tue, 07 Dec 2010 16:05:02 -0500	[thread overview]
Message-ID: <20101207210502.GC6510@denix.org> (raw)
In-Reply-To: <1291749231-15483-1-git-send-email-j-lance1@ti.com>

On Tue, Dec 07, 2010 at 01:13:50PM -0600, Jeff Lance wrote:
> * Added Matrix Enhancements:
>   * Added new platforms am180x, am181x and am3517
>   * add control menubar at the top of matrix-gui (HTML change not code change)
>   * add descriptions to matrix applications (source code change)
>   * make matrix scalable with respect to number of applications.
>     * allow addtional main menu pages and allow additional sub-menu pages (source code change)
> 
> NOTE: code changes are backwards compatible with existing platform support files.

Jeff, Chase,

The only comment I have is that in the first patch you add new .bb files with 
latest SRCREV and for some reason bump INC_PR in the .inc files, altough there 
are no changes there. Then in the second patch you update the .inc files and 
don't bump the INC_PR. It would make more sense to increment INC_PR as part of 
the second patch and not the first.

-- 
Denys


> Signed-off-by: Jeff Lance <j-lance1@ti.com>
> Signed-off-by: Chase Maupin <chase.maupin@ti.com>
> ---
>  recipes/ti/matrix-gui-common.inc    |    2 +-
>  recipes/ti/matrix-gui-common_1.4.bb |    8 ++++++++
>  recipes/ti/matrix-gui-e.inc         |    2 +-
>  recipes/ti/matrix-gui-e_1.3.bb      |    5 +++++
>  recipes/ti/matrix-gui.inc           |    2 +-
>  recipes/ti/matrix-gui_1.3.bb        |    4 ++++
>  6 files changed, 20 insertions(+), 3 deletions(-)
>  create mode 100644 recipes/ti/matrix-gui-common_1.4.bb
>  create mode 100644 recipes/ti/matrix-gui-e_1.3.bb
>  create mode 100644 recipes/ti/matrix-gui_1.3.bb
> 
> diff --git a/recipes/ti/matrix-gui-common.inc b/recipes/ti/matrix-gui-common.inc
> index b5a368e..2d2cea3 100644
> --- a/recipes/ti/matrix-gui-common.inc
> +++ b/recipes/ti/matrix-gui-common.inc
> @@ -4,7 +4,7 @@ LICENSE = "BSD"
>  SECTION = "multimedia"
>  PRIORITY = "optional"
>  
> -INC_PR = "r5"
> +INC_PR = "r6"
>  
>  COMPATIBLE_MACHINE = "(dm365|omapl138|omap3|ti816x)"
>  
> diff --git a/recipes/ti/matrix-gui-common_1.4.bb b/recipes/ti/matrix-gui-common_1.4.bb
> new file mode 100644
> index 0000000..c578a47
> --- /dev/null
> +++ b/recipes/ti/matrix-gui-common_1.4.bb
> @@ -0,0 +1,8 @@
> +require matrix-gui-common.inc
> +
> +# Use the mem_util application from am-sysinfo instead of a
> +# prebuilt version in the repository.
> +RRECOMMENDS_${PN} = "am-sysinfo"
> +
> +SRCREV = "192"
> +PR = "${INC_PR}.0"
> diff --git a/recipes/ti/matrix-gui-e.inc b/recipes/ti/matrix-gui-e.inc
> index 86f08b1..c3a9341 100644
> --- a/recipes/ti/matrix-gui-e.inc
> +++ b/recipes/ti/matrix-gui-e.inc
> @@ -4,7 +4,7 @@ LICENSE = "BSD"
>  SECTION = "multimedia"
>  PRIORITY = "optional"
>  
> -INC_PR = "r20"
> +INC_PR = "r21"
>  
>  COMPATIBLE_MACHINE = "(dm365|omapl138|omap3|ti816x)"
>  
> diff --git a/recipes/ti/matrix-gui-e_1.3.bb b/recipes/ti/matrix-gui-e_1.3.bb
> new file mode 100644
> index 0000000..dd1b16b
> --- /dev/null
> +++ b/recipes/ti/matrix-gui-e_1.3.bb
> @@ -0,0 +1,5 @@
> +require matrix-gui-e.inc
> +
> +SRCREV = "192"
> +PR = "${INC_PR}.0"
> +
> diff --git a/recipes/ti/matrix-gui.inc b/recipes/ti/matrix-gui.inc
> index a2a2721..b7678b2 100644
> --- a/recipes/ti/matrix-gui.inc
> +++ b/recipes/ti/matrix-gui.inc
> @@ -4,7 +4,7 @@ LICENSE = "BSD"
>  SECTION = "multimedia"
>  PRIORITY = "optional"
>  
> -INC_PR = "r18"
> +INC_PR = "r19"
>  
>  COMPATIBLE_MACHINE = "(dm365|omapl138|omap3|ti816x)"
>  
> diff --git a/recipes/ti/matrix-gui_1.3.bb b/recipes/ti/matrix-gui_1.3.bb
> new file mode 100644
> index 0000000..53db8af
> --- /dev/null
> +++ b/recipes/ti/matrix-gui_1.3.bb
> @@ -0,0 +1,4 @@
> +require matrix-gui.inc
> +
> +SRCREV = "192"
> +PR = "${INC_PR}.0"
> -- 
> 1.6.3.3
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  parent reply	other threads:[~2010-12-07 21:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 19:13 [PATCH 1/2] matrix-gui: updating SRC rev to pick up new platforms and matrix code enhancements Jeff Lance
2010-12-07 19:13 ` [PATCH 2/2] matrix-gui: add additional platform support Jeff Lance
2010-12-07 21:05 ` Denys Dmytriyenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-08  0:26 [PATCH 1/2] matrix-gui: updating SRC rev to pick up new platforms and matrix code enhancements Jeff Lance

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101207210502.GC6510@denix.org \
    --to=denis@denix.org \
    --cc=j-lance1@ti.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.