From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.atheros.com ([12.19.149.2]:25762 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754963Ab0LGVYT (ORCPT ); Tue, 7 Dec 2010 16:24:19 -0500 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Tue, 07 Dec 2010 13:24:04 -0800 Date: Tue, 7 Dec 2010 13:24:16 -0800 From: "Luis R. Rodriguez" To: "John W. Linville" CC: Luis Rodriguez , "johannes@sipsolutions.net" , "linux-wireless@vger.kernel.org" , Amod Bodas , "pstew@google.com" , "stable@kernel.org" Subject: Re: [PATCH 2/3] ath9k: Fix power save count imbalance on ath_radio_enable() Message-ID: <20101207212416.GB2582@tux> References: <1291425653-2884-1-git-send-email-lrodriguez@atheros.com> <1291425653-2884-3-git-send-email-lrodriguez@atheros.com> <20101207210130.GM2700@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20101207210130.GM2700@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Dec 07, 2010 at 01:01:30PM -0800, John W. Linville wrote: > On Fri, Dec 03, 2010 at 05:34:08PM -0800, Luis R. Rodriguez wrote: > > On Fri, Dec 3, 2010 at 5:20 PM, Luis R. Rodriguez > > wrote: > > > Upon a failure we never call ath9k_ps_restore() on ath_radio_enable(), > > > this will throw off the sc->ps_usecount. When the sc->ps_usecount > > > is > 0 we never put the chip to full sleep. This drains battery, > > > and will also make the chip fail upon resume with: > > > > > > ath: Starting driver with initial channel: 5745 MHz > > > ath: timeout (100000 us) on reg 0x7000: 0xdeadbeef & 0x00000003 != 0x00000000 > > > > > > This would make the chip useless upon resume. > > > > > > I cannot prove this can happen but in theory it is so best to > > > avoid this race completely and not have users complain about > > > a broken device after resume. > > > > > > Cc: stable@kernel.org > > > Cc: Paul Stewart > > > Cc: Amod Bodas > > > Signed-off-by: Luis R. Rodriguez > > > > John, this one is for you, sorry I failed to send it to you. And > > Johannes, sorry, I forgot to remove you from my send script :) > > So, this is for 2.6.37? Yes. > FWIW, it was the only PATCH in a series of RFCs... Thanks, yes, I noted this on my PATCH 0 cover letter. If you want you can disrecard this though and just consider the PATCH I posted in my new series. Its in that series as well, but let me just iron out that series first, please ignore that series as well for now. Luis