All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Pull request buildroot.git (vapier branch)
Date: Tue, 7 Dec 2010 21:35:18 +0100	[thread overview]
Message-ID: <20101207213518.61b77079@surf> (raw)
In-Reply-To: <8762v5u5r5.fsf@macbook.be.48ers.dk>

On Tue, 07 Dec 2010 13:28:14 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

> And as this will be most packages, we should probably do something
> like BR2_PACKAGE_BUSYBOX_SHOW_OTHERS - E.G. add this dependency in
> package/Config.in instead of moving it down to each individual
> package.

I don't think we should do that. With three options to handle
(BUSYBOX_SHOW_OTHERS, USE_MMU and PREFER_STATIC_LIB), the
package/Config.in is going to become a nightmare to read, and the fact
that the current if's in package/Config.in can be common to several
packages will be very reduced because of the three conditions.

On the opposite, I would have suggested to move these to the
per-package Config.in. Yes, it's a bit more code, but it's not a big
deal, and will make it easier to maintain.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-12-07 20:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-04 22:52 [Buildroot] Pull request buildroot.git (vapier branch) Mike Frysinger
2010-12-05 10:57 ` Thomas Petazzoni
2010-12-05 12:19   ` Thomas Petazzoni
2010-12-06  6:56     ` Mike Frysinger
2010-12-06 19:27       ` Thomas Petazzoni
2010-12-06 20:10         ` Mike Frysinger
2010-12-07 12:28         ` Peter Korsgaard
2010-12-07 20:35           ` Thomas Petazzoni [this message]
2010-12-07 21:31           ` Mike Frysinger
2010-12-07 21:48             ` Peter Korsgaard
2010-12-07 22:02               ` Mike Frysinger
2010-12-06  7:50   ` Mike Frysinger
2010-12-06 19:39     ` Thomas Petazzoni
2010-12-06 20:20       ` Mike Frysinger
2010-12-06 20:44         ` Thomas Petazzoni
2010-12-06 20:55           ` Mike Frysinger
  -- strict thread matches above, loose matches on Subject: below --
2011-02-07  5:49 Mike Frysinger
2011-01-20  3:10 Mike Frysinger
2011-01-10 14:28 Mike Frysinger
2010-11-23 21:48 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101207213518.61b77079@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.