From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 1/2] ASoC: omap: Add hardware constraint for HDMI and ABE Date: Wed, 8 Dec 2010 11:11:40 +0200 Message-ID: <201012081111.40323.peter.ujfalusi@nokia.com> References: <1889FA7136B567478A67D4B0F85B0CCEA4C52E80@dlee06.ent.ti.com> <201012071057.24139.peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mgw-sa02.nokia.com (smtp.nokia.com [147.243.1.48]) by alsa0.perex.cz (Postfix) with ESMTP id BCAEC24396 for ; Wed, 8 Dec 2010 10:11:45 +0100 (CET) In-Reply-To: <201012071057.24139.peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: "ext Olaya, Margarita" , Mark Brown , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tuesday 07 December 2010 10:57:24 Ujfalusi Peter (Nokia-MS/Tampere) wrot= e: > On Tuesday 07 December 2010 00:34:44 ext Olaya, Margarita wrote: > > From: Jorge Eduardo Candelaria > > = > > The Audio Backend needs a step size of 24 * 4, while HDMI requires a > > step size of 32 * 4 bits to align the audio buffer. ... > Few things: > This only applicable for OMAP4, so please make it so that it only applies > to OMAP4. > We have the other constraints set in the > omap-mcbsp.c:omap_mcbsp_dai_startup. I think it would be better to keep > them in a same place. One more thing: Since this is ABE/HDMI specific constraint, I would add this from the = corresponding codec driver rather than setting this for all McBSP ports = regardless if it is used with HDMI or not. -- = P=E9ter