All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Bruno Randolf <br1@einfach.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: Add antenna availability information
Date: Wed, 8 Dec 2010 09:31:01 -0500	[thread overview]
Message-ID: <20101208143101.GC2423@tuxdriver.com> (raw)
In-Reply-To: <20101208034429.24218.50707.stgit@localhost6.localdomain6>

On Wed, Dec 08, 2010 at 12:44:29PM +0900, Bruno Randolf wrote:
> Add a field to wiphy for the hardware to report the availble antennas for
> configuration. Only if this is set to something bigger than zero, will the
> anntenna configuration ops be executed.
> 
> Allthough this could be a simple number of antennas, I defined it as a bitmap
> of antennas which are available for configuration, since it's more consistent
> with the rest of the antenna API and there could be cases where the
> hardware allows only configuration of certain antennas. As it does not make
> much of a difference in size or normal usage, I think it's better to be able to
> support this, in case the need arises.
> 
> The antenna configuration is now also checked against the availabe antennas and
> rejected if it does not match.
> 
> Signed-off-by: Bruno Randolf <br1@einfach.org>
> 
> v2:	reject antenna configurations which don't match the available antennas
> ---

Please either put the "v2" part before the "Signed-off-by" or
(preferably) after the "---" line.  Also, make sure to use 3 "-"
characters -- often you use only 2 of them and the results from
applying with "git am" are messy.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  parent reply	other threads:[~2010-12-08 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08  3:44 [PATCH v2] cfg80211: Add antenna availability information Bruno Randolf
2010-12-08  4:49 ` Bruno Randolf
2010-12-08 14:31 ` John W. Linville [this message]
2010-12-10 12:47   ` Bruno Randolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208143101.GC2423@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=br1@einfach.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.