All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: fbgrab
Date: Wed, 8 Dec 2010 20:30:36 +0100	[thread overview]
Message-ID: <20101208203036.1ca0d3bb@surf> (raw)
In-Reply-To: <1291764170-11947-1-git-send-email-daniel.nystrom@timeterminal.se>

Hello,

Thanks for proposing this package!

On Wed,  8 Dec 2010 00:22:50 +0100
Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:

> FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

The git commit log should be wrapped at a reasonable limit (~ 80
columns).

> diff --git a/package/fbgrab/Config.in b/package/fbgrab/Config.in
> new file mode 100644
> index 0000000..0ede91e
> --- /dev/null
> +++ b/package/fbgrab/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_FBGRAB
> +	bool "fbgrab"
> +	select BR2_PACKAGE_LIBPNG
> +        select BR2_PACKAGE_ZLIB

Indentation issue. It should be one tab before bool/select/help, and
the help message itself should be indented with one tab + 2 spaces.

> +	help
> +	  FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

Should be wrapped at a reasonable limit as well.

> diff --git a/package/fbgrab/fbgrab-proper_makefile.patch b/package/fbgrab/fbgrab-proper_makefile.patch
> new file mode 100644
> index 0000000..8f7919e
> --- /dev/null
> +++ b/package/fbgrab/fbgrab-proper_makefile.patch

Peter wants each patch to have a description and an author here.

> @@ -0,0 +1,16 @@
> +--- fbgrab-1.0.orig/Makefile	2010-12-07 22:57:24.000000000 +0100
> ++++ fbgrab-1.0/Makefile	2010-12-07 22:58:36.000000000 +0100
> +@@ -3,9 +3,10 @@
> + ### modular. So this is a simple gnu Makefile...
> + ###
> + 
> +-fbgrab: fbgrab.c
> +-	splint +posixlib fbgrab.c
> +-	gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
> ++LDFLAGS += -lpng -lz
> ++
> ++fbgrab: fbgrab.o
> ++	$(CC) $(LDFLAGS) fbgrab.o -o $@
> + 
> + install:
> + 	strip fbgrab
> diff --git a/package/fbgrab/fbgrab.mk b/package/fbgrab/fbgrab.mk
> new file mode 100644
> index 0000000..459fd37
> --- /dev/null
> +++ b/package/fbgrab/fbgrab.mk
> @@ -0,0 +1,16 @@
> +FBGRAB_VERSION = 1.0
> +FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
> +FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
> +FBGRAB_DEPENDENCIES = libpng zlib
> +
> +define FBGRAB_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
> +		LDFLAGS="$(TARGET_LDFLAGS)" \
> +		$(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
> +endef

Can you try to see if using $(TARGET_CONFIGURE_OPTS) is possible to
pass CFLAGS/LDFLAGS/CC/LD ?

> +define FBGRAB_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
> +endef

This will install "fbgrab" as a file named "bin" in $(TARGET_DIR)/usr.
So the line should be :

$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin/fbgrab

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-12-08 19:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 23:22 [Buildroot] [PATCH] New package: fbgrab Daniel Nyström
2010-12-08 19:30 ` Thomas Petazzoni [this message]
2010-12-09 15:32   ` Daniel Nyström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208203036.1ca0d3bb@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.