From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [stable] [PATCH] drm/kms: remove spaces from connector names Date: Wed, 8 Dec 2010 15:30:26 -0800 Message-ID: <20101208233026.GA10898@kroah.com> References: <1291850043-7742-1-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from coco.kroah.org (kroah.org [198.145.64.141]) by gabe.freedesktop.org (Postfix) with ESMTP id 673AA9E744 for ; Wed, 8 Dec 2010 15:30:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <1291850043-7742-1-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: Sergej Pupykin , dri-devel@lists.freedesktop.org, stable@kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: > Grub doesn't parse spaces in parameters correctly, so > this makes it impossible to force video= parameters > for kms on the grub kernel command line. > > Reported-by: Sergej Pupykin > > Cc: Sergej Pupykin > Signed-off-by: Alex Deucher > Cc: stable@kernel.org > --- > drivers/gpu/drm/drm_crtc.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 6985cb1..7ee7a2f 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = > { DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 }, > { DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 }, > { DRM_MODE_CONNECTOR_Component, "Component", 0 }, > - { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 }, What kernel version did these options first show up in? Does any other tools rely on the spaces? thanks, greg k-h