All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Sergej Pupykin <ml@sergej.pp.ru>
Cc: Alex Deucher <alexdeucher@gmail.com>, Greg KH <greg@kroah.com>,
	stable@kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/kms: remove spaces from connector names
Date: Thu, 9 Dec 2010 09:46:23 -0800	[thread overview]
Message-ID: <20101209094623.1f46b4cb@jbarnes-desktop> (raw)
In-Reply-To: <87aakec0m9.wl%sergej.pupykin@dsr-company.com>

On Thu, 09 Dec 2010 20:33:18 +0300
Sergej Pupykin <ml@sergej.pp.ru> wrote:

> At Thu, 9 Dec 2010 09:18:14 -0800,
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> > On Wed, 8 Dec 2010 15:30:26 -0800
> > Greg KH <greg@kroah.com> wrote:
> > > What kernel version did these options first show up in?  Does any
> > > other tools rely on the spaces?
> > 
> > And it's ugly; can't we fix grub instead?
> 
> I think renaming connectors is good idea anyway. It should be typed
> before system boot, so names should be short and easy kept in mind.
> 
> Such as TV, DIN, VGA, DVI, etc...

I prefer to keep the user visible names as they are, they're
descriptive and easy to read with spaces.

An alternative to fixing grub would be to add aliases like you mention,
and/or change the parser to accept "_" as an alias for " ".  Then we
could leave the sysfs values and string table alone.

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2010-12-09 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 23:14 [PATCH] drm/kms: remove spaces from connector names Alex Deucher
2010-12-08 23:30 ` [stable] " Greg KH
2010-12-08 23:32   ` Dave Airlie
2010-12-09 17:18   ` Jesse Barnes
2010-12-09 17:33     ` Sergej Pupykin
2010-12-09 17:46       ` Jesse Barnes [this message]
2010-12-09 22:15         ` [stable] " Peter Stuge
2010-12-10 12:24     ` Sergej Pupykin
2010-12-10 18:05       ` Peter Stuge
2010-12-13 10:43         ` [stable] " Sergej Pupykin
2010-12-13 11:31           ` Sergej Pupykin
2010-12-09  0:01 ` Dave Airlie
2010-12-09  0:04   ` Alex Deucher
2010-12-09  0:09   ` [PATCH] drm/kms: remove spaces from connector names (v2) Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101209094623.1f46b4cb@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg@kroah.com \
    --cc=ml@sergej.pp.ru \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.