All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: log timestamp changes to the source inode in rename
Date: Thu, 9 Dec 2010 21:36:05 +1100	[thread overview]
Message-ID: <20101209103605.GC29856@dastard> (raw)
In-Reply-To: <20101207101641.GA25995@infradead.org>

On Tue, Dec 07, 2010 at 05:16:41AM -0500, Christoph Hellwig wrote:
> Now that we don't mark VFS inodes dirty anymore for internal timestamp changes,
> but rely on the transaction subsystem to push them out, we need to explicitly
> log the source inode in rename after updating it's timestamps to make sure
> the changes actually get forced out by sync/fsync or an AIL push.
> 
> We already account for the fourth inode in the log reservation, as a rename
> of directories needs to update the nlink field, so just adding the
> xfs_trans_log_inode call is enough.
> 
> This fixes the xfsqa 065 regression introduced by:
> 
> 	"xfs: don't use vfs writeback for pure metadata modifications"
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-12-09 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 10:16 [PATCH] xfs: log timestamp changes to the source inode in rename Christoph Hellwig
2010-12-09 10:36 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101209103605.GC29856@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.