From: Dan Carpenter <error27@gmail.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs.
Date: Thu, 9 Dec 2010 13:43:36 +0300 [thread overview]
Message-ID: <20101209104336.GT10623@bicker> (raw)
In-Reply-To: <1291890413-15255-2-git-send-email-marek.belisko@open-nandra.com>
> + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir,
^^^^^^^
> + NULL, &ft1000fops);
Don't make this world writeable.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-09 10:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 10:26 [PATCH 0/8] Use debugfs for debugging purposes Marek Belisko
2010-12-09 10:26 ` [PATCH 1/8] staging: ft1000: Convert char device to debugfs Marek Belisko
2010-12-09 10:43 ` Dan Carpenter [this message]
2010-12-10 17:35 ` Dave Jones
2010-12-10 18:04 ` Greg KH
2010-12-09 10:26 ` [PATCH 2/8] staging: ft1000: Fix private data pointer usage Marek Belisko
2010-12-09 10:26 ` [PATCH 3/8] staging: ft1000: Remove unused pdevobj array Marek Belisko
2010-12-09 10:26 ` [PATCH 4/8] staging: ft1000: Remove unused variable Marek Belisko
2010-12-09 10:26 ` [PATCH 5/8] staging: ft1000: Fix camelcase functions and variables Marek Belisko
2010-12-09 10:26 ` [PATCH 6/8] staging: ft1000: Remove dead code Marek Belisko
2010-12-09 10:26 ` [PATCH 7/8] staging: ft1000: Remove unused headers Marek Belisko
2010-12-09 10:26 ` [PATCH 8/8] staging: ft1000: Fix debug messages Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209104336.GT10623@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.