From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Wong Subject: Re: Intermittent failures in t9119 Date: Thu, 9 Dec 2010 17:55:03 +0000 Message-ID: <20101209175503.GA16478@dcvr.yhbt.net> References: <7vmxoml1p7.fsf@alter.siamese.dyndns.org> <7vy684t0mt.fsf@alter.siamese.dyndns.org> <20101206191055.GA9597@dcvr.yhbt.net> <7vd3pesb99.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David D. Kilzer" , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Dec 09 18:55:12 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PQki0-0004ej-CU for gcvg-git-2@lo.gmane.org; Thu, 09 Dec 2010 18:55:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653Ab0LIRzF (ORCPT ); Thu, 9 Dec 2010 12:55:05 -0500 Received: from dcvr.yhbt.net ([64.71.152.64]:48281 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944Ab0LIRzE (ORCPT ); Thu, 9 Dec 2010 12:55:04 -0500 Received: from localhost (unknown [127.0.2.5]) by dcvr.yhbt.net (Postfix) with ESMTP id C4B9E1F8CF; Thu, 9 Dec 2010 17:55:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7vd3pesb99.fsf@alter.siamese.dyndns.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > Eric Wong writes: > > Junio C Hamano wrote: > >> (2) Nobody uses the value from "Text Last Updated" field in practice, so > >> that bug has been unnoticed so far; > >> > >> (3) And it is not worth fixing it ;-) > >> > >> For now, I would suggest fixing the failing test to ignore the "Text Last > >> Updated" field while comparing, and if somebody is inclined to, we would > >> update the code to match what "svn info" does. > > > > Agreed on both points. I consider "git svn log" and "git svn info" to > > be reasonable approximations of svn behavior, not exact replicas. > > Exactly matching would be extremely difficult given variations between > > different svn versions, and also svn requiring network access while > > git svn does not. > > Ok, here is a minimum patch to do that. > Signed-off-by: Junio C Hamano Thanks, Acked-by: Eric Wong -- Eric Wong