Re: [PATCH 2/2]input - wacom_w8001: Add one finger touch support

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Dec 09, 2010 at 11:36:19AM -0800, Ping Cheng wrote:
> On Thu, Dec 9, 2010 at 7:06 AM, Chris Bagwell <chris@cnpbagwell.com> wrote:
> > On Wed, Dec 8, 2010 at 7:23 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> >> @@ -228,9 +277,17 @@ static irqreturn_t w8001_interrupt(struct serio *serio,
> >>                if (tmp == W8001_TOUCH_BYTE)
> >>                        break;
> >>
> >> +               if (w8001->has_touch) {
> >> +                       /* send touch data out */
> >> +                       w8001->has_touch = 0;
> >> +                       input_report_key(dev, BTN_TOUCH, 0);
> >> +                       input_report_key(dev, BTN_TOOL_FINGER, 0);
> >
> > Probably its better to set ABS_X/ABS_Y to zero and do a sync here?  So
> > duplicate x/y values don't get dropped and aligns with wacom_wac.c.
> > This is related to comment about forcing ABS_X/Y to zero above.  Its
> > so pen has known starting point when coming in proximity.  I wouldn't
> > do one without the other.
> 
> I'll do both to make you happy (just kidding, to make it safe ;).
> 

Actually do not see how (0,0) is any safer than let's say (123,78)
sincve i believe (0,0) is a valid coordinate. Userspace should still
hang on to the last reported coordinate and use it if it did not get
a new one.

Also, if you add input_sync() here won't it cause (in certain
situtations) false click or tap events - BTN_TOUCH goes from 1 to 0 and
then again to 1 if pen is already in proximity...

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html