From: Jonathan Nieder <jrnieder@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "J.H." <warthog9@eaglescrag.net>,
git@vger.kernel.org, John 'Warthog9' Hawley <warthog9@kernel.org>,
Junio C Hamano <gitster@pobox.com>, Petr Baudis <pasky@ucw.cz>,
admin@repo.or.cz, olaf@wundersolutions.com
Subject: Re: [RFC] Implementing gitweb output caching - issues to solve
Date: Thu, 9 Dec 2010 16:52:11 -0600 [thread overview]
Message-ID: <20101209225211.GA20426@burratino> (raw)
In-Reply-To: <201012092330.06688.jnareb@gmail.com>
Jakub Narebski wrote:
> In my rewrite
>
> [PATCHv6 17/24] gitweb: Show appropriate "Generating..." page when regenerating cache
> http://thread.gmane.org/gmane.comp.version-control.git/163052/focus=163040
> http://repo.or.cz/w/git/jnareb-git.git/commitdiff/48679f7985ccda16dc54fda97790841bab4a0ba2#patch1
>
> (see the browser_is_robot() subroutine:
>
> http://repo.or.cz/w/git/jnareb-git.git/blob/48679f7985ccda16dc54fda97790841bab4a0ba2:/gitweb/gitweb.perl#l870
>
> I use HTTP::BrowserDetect package if available and it's ->robot() method.
>
> The fallback is to use *whitelist*, assuming that it would be better to
> not show "Generating..." page rather than download the wrong thing.
> I also guess that most (all?) web browsers use "Mozilla compatibile"
> somewhere in their User-Agent string, thus matching 'Mozilla'.
Interesting. http://www.user-agents.org/ seems to suggest that many
robots do use Mozilla (though I don't think it's worth bending over
backwards to help them see the page correctly).
HTTP::BrowserDetect uses a blacklist as far as I can tell. Maybe in
the long term it would be nice to add a whitelist ->human() method.
Cc-ing Olaf Alders for ideas.
next prev parent reply other threads:[~2010-12-09 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 16:21 [RFC] Implementing gitweb output caching - issues to solve Jakub Narebski
2010-12-09 1:31 ` J.H.
2010-12-09 5:22 ` Junio C Hamano
2010-12-09 5:28 ` J.H.
2010-12-09 22:30 ` Jakub Narebski
2010-12-09 22:52 ` Jonathan Nieder [this message]
2010-12-10 3:17 ` Olaf Alders
2010-12-10 4:11 ` Jonathan Nieder
2010-12-10 4:46 ` J.H.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209225211.GA20426@burratino \
--to=jrnieder@gmail.com \
--cc=admin@repo.or.cz \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=olaf@wundersolutions.com \
--cc=pasky@ucw.cz \
--cc=warthog9@eaglescrag.net \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.