diff for duplicates of <20101210103642.GK20133@csn.ul.ie> diff --git a/a/1.txt b/N1/1.txt index 4f8fc03..4dbd913 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,44 +23,44 @@ Done. > A comment below. > > > --- -> > mm/vmscan.c | 14 ++++++++++---- -> > 1 files changed, 10 insertions(+), 4 deletions(-) +> > mm/vmscan.c | 14 ++++++++++---- +> > 1 files changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index b4472a1..52e229e 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2132,7 +2132,7 @@ static bool pgdat_balanced(pg_data_t *pgdat, unsigned long balanced) -> > } +> > } > > -> > /* is kswapd sleeping prematurely? */ +> > /* is kswapd sleeping prematurely? */ > > -static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining) > > +static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining) -> > { -> > int i; -> > unsigned long balanced = 0; +> > { +> > int i; +> > unsigned long balanced = 0; > > @@ -2142,7 +2142,7 @@ static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining) -> > if (remaining) -> > return 1; +> > if (remaining) +> > return 1; > > -> > - /* If after HZ/10, a zone is below the high mark, it's premature */ -> > + /* Check the watermark levels */ -> > for (i = 0; i < pgdat->nr_zones; i++) { -> > struct zone *zone = pgdat->node_zones + i; +> > - /* If after HZ/10, a zone is below the high mark, it's premature */ +> > + /* Check the watermark levels */ +> > for (i = 0; i < pgdat->nr_zones; i++) { +> > struct zone *zone = pgdat->node_zones + i; > > > > @@ -2427,7 +2427,13 @@ out: -> > } -> > } +> > } +> > } > > -> > - return sc.nr_reclaimed; -> > + /* -> > + * Return the order we were reclaiming at so sleeping_prematurely() -> > + * makes a decision on the order we were last reclaiming at. However, -> > + * if another caller entered the allocator slow path while kswapd -> > + * was awake, order will remain at the higher level -> > + */ -> > + return order; -> > } +> > - return sc.nr_reclaimed; +> > + /* +> > + * Return the order we were reclaiming at so sleeping_prematurely() +> > + * makes a decision on the order we were last reclaiming at. However, +> > + * if another caller entered the allocator slow path while kswapd +> > + * was awake, order will remain at the higher level +> > + */ +> > + return order; +> > } > > Please change return value description of balance_pgdat. > "Returns the number of pages which were actually freed" @@ -72,3 +72,10 @@ Oops, done. Thanks Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 4f4fa8e..6013021 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -40,44 +40,44 @@ "> A comment below.\n" "> \n" "> > ---\n" - "> > \302\240mm/vmscan.c | \302\240 14 ++++++++++----\n" - "> > \302\2401 files changed, 10 insertions(+), 4 deletions(-)\n" + "> > mm/vmscan.c | 14 ++++++++++----\n" + "> > 1 files changed, 10 insertions(+), 4 deletions(-)\n" "> >\n" "> > diff --git a/mm/vmscan.c b/mm/vmscan.c\n" "> > index b4472a1..52e229e 100644\n" "> > --- a/mm/vmscan.c\n" "> > +++ b/mm/vmscan.c\n" "> > @@ -2132,7 +2132,7 @@ static bool pgdat_balanced(pg_data_t *pgdat, unsigned long balanced)\n" - "> > \302\240}\n" + "> > }\n" "> >\n" - "> > \302\240/* is kswapd sleeping prematurely? */\n" + "> > /* is kswapd sleeping prematurely? */\n" "> > -static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)\n" "> > +static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)\n" - "> > \302\240{\n" - "> > \302\240 \302\240 \302\240 \302\240int i;\n" - "> > \302\240 \302\240 \302\240 \302\240unsigned long balanced = 0;\n" + "> > {\n" + "> > int i;\n" + "> > unsigned long balanced = 0;\n" "> > @@ -2142,7 +2142,7 @@ static int sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)\n" - "> > \302\240 \302\240 \302\240 \302\240if (remaining)\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240return 1;\n" + "> > if (remaining)\n" + "> > return 1;\n" "> >\n" - "> > - \302\240 \302\240 \302\240 /* If after HZ/10, a zone is below the high mark, it's premature */\n" - "> > + \302\240 \302\240 \302\240 /* Check the watermark levels */\n" - "> > \302\240 \302\240 \302\240 \302\240for (i = 0; i < pgdat->nr_zones; i++) {\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240struct zone *zone = pgdat->node_zones + i;\n" + "> > - /* If after HZ/10, a zone is below the high mark, it's premature */\n" + "> > + /* Check the watermark levels */\n" + "> > for (i = 0; i < pgdat->nr_zones; i++) {\n" + "> > struct zone *zone = pgdat->node_zones + i;\n" "> >\n" "> > @@ -2427,7 +2427,13 @@ out:\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240}\n" - "> > \302\240 \302\240 \302\240 \302\240}\n" + "> > }\n" + "> > }\n" "> >\n" - "> > - \302\240 \302\240 \302\240 return sc.nr_reclaimed;\n" - "> > + \302\240 \302\240 \302\240 /*\n" - "> > + \302\240 \302\240 \302\240 \302\240* Return the order we were reclaiming at so sleeping_prematurely()\n" - "> > + \302\240 \302\240 \302\240 \302\240* makes a decision on the order we were last reclaiming at. However,\n" - "> > + \302\240 \302\240 \302\240 \302\240* if another caller entered the allocator slow path while kswapd\n" - "> > + \302\240 \302\240 \302\240 \302\240* was awake, order will remain at the higher level\n" - "> > + \302\240 \302\240 \302\240 \302\240*/\n" - "> > + \302\240 \302\240 \302\240 return order;\n" - "> > \302\240}\n" + "> > - return sc.nr_reclaimed;\n" + "> > + /*\n" + "> > + * Return the order we were reclaiming at so sleeping_prematurely()\n" + "> > + * makes a decision on the order we were last reclaiming at. However,\n" + "> > + * if another caller entered the allocator slow path while kswapd\n" + "> > + * was awake, order will remain at the higher level\n" + "> > + */\n" + "> > + return order;\n" + "> > }\n" "> \n" "> Please change return value description of balance_pgdat.\n" "> \"Returns the number of pages which were actually freed\"\n" @@ -88,6 +88,13 @@ "-- \n" "Mel Gorman\n" "Part-time Phd Student Linux Technology Center\n" - University of Limerick IBM Dublin Software Lab + "University of Limerick IBM Dublin Software Lab\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -4f1ba670c0c529ce8db8ee847316465e1b3f771911ff238d8bc34e99a09c5b25 +fcb1456f7113ceb7c868b0217ca4514b30bfb0a3856958f95255b562f63edab0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.