All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: tlv320dac33: Power down digital parts, when not needed
Date: Fri, 10 Dec 2010 13:21:10 +0200	[thread overview]
Message-ID: <201012101321.10329.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101210104449.GA3200@rakim.wolfsonmicro.main>

On Friday 10 December 2010 12:44:49 ext Mark Brown wrote:
> On Fri, Dec 10, 2010 at 12:14:49PM +0200, Peter Ujfalusi wrote:
> > If the following scenarion has been followed:
> > 1. Enable analog bypass
> > amixer sset 'Analog Left Bypass' on
> > amixer sset 'Analog Right Bypass' on
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> It'd have been nice to have mentioned how the digital gets turned back
> on in the changelog!

Currently the codec is going to be reset at every stream start, since it can get 
confused, if I fail to do that, especially, when the FIFO is enabled.
In case, when the bypass was not enabled the codec anyway will hit BIAS_OFF, so 
next time, when we power it on, it is going through the power-up sequence.

I do have some plans to actually remove the need for this reset requirement at 
every stream start (it adds considerable amount of latency, and other unwanted 
side effects).

I can resend the patch with updated changelog.

-- 
Péter

  reply	other threads:[~2010-12-10 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 10:14 [PATCH] ASoC: tlv320dac33: Power down digital parts, when not needed Peter Ujfalusi
2010-12-10 10:44 ` Mark Brown
2010-12-10 11:21   ` Peter Ujfalusi [this message]
2010-12-10 12:23     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012101321.10329.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.