From: Paul Brook <paul@codesourcery.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host
Date: Fri, 10 Dec 2010 15:17:18 +0000 [thread overview]
Message-ID: <201012101517.18342.paul@codesourcery.com> (raw)
In-Reply-To: <20101210145957.GD15015@amit-x200.redhat.com>
> On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > > - if (!discard) {
> > > + if (discard) {
> > > + goto next;
> > > + }
> > >
> > > + next:
> > > virtqueue_push(vq, &elem, 0);
> >
> > Please don't do this.
>
> Could you elaborate?
>
> I can move the 'discard' check into the following 'for' loop, but since
> the value of discard doesn't change, I moved it outside.
You've replaced a perfectly good if block with a goto.
Paul
next prev parent reply other threads:[~2010-12-10 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 13:25 [Qemu-devel] [PATCH 0/5] virtio-serial: Trivial fixes, don't copy buffers to host Amit Shah
2010-12-10 13:25 ` [Qemu-devel] [PATCH 1/5] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-12-10 13:25 ` [Qemu-devel] [PATCH 2/5] virtio-console: Remove unnecessary braces Amit Shah
2010-12-10 13:25 ` [Qemu-devel] [PATCH 3/5] virtio-serial: Simplify condition for a while loop Amit Shah
2010-12-10 13:25 ` [Qemu-devel] [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host Amit Shah
2010-12-10 14:02 ` [Qemu-devel] " Paul Brook
2010-12-10 14:59 ` Amit Shah
2010-12-10 15:17 ` Paul Brook [this message]
2010-12-10 15:26 ` Amit Shah
2010-12-10 13:25 ` [Qemu-devel] [PATCH 5/5] virtio-serial: Error out if guest sends unexpected vq elements Amit Shah
2010-12-10 13:59 ` [Qemu-devel] " Paul Brook
2010-12-10 14:59 ` Amit Shah
2010-12-10 15:17 ` Paul Brook
2010-12-10 15:30 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012101517.18342.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.