All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2] lm-sensors: Add support for new hwmon
Date: Fri, 10 Dec 2010 17:37:14 +0000	[thread overview]
Message-ID: <20101210173714.GA12627@ericsson.com> (raw)
In-Reply-To: <1278567813-9608-1-git-send-email-guenter.roeck@ericsson.com>

On Thu, Dec 09, 2010 at 03:31:30PM -0500, Jean Delvare wrote:
> On Thu, 9 Dec 2010 07:40:46 -0800, Guenter Roeck wrote:
> > Actually, I think I'll have to re-do the whole patch anyway. As you pointed out,
> > it does not reflect the documented attributes, and there are other problems 
> > such as how and when to display alarms. Without going into details,
> > I don't think we really disagree on anything
> 
> I agree.
> 
> > - the idea was to retain the existing output.
> 
> Up to a certain point, yes. Where the current output was decided
> because it made sense, we want to keep it as is. But being identical to
> the character isn't a goal per se. In particular, if switching to more
> generic code is possible and makes the code smaller and/or more
> readable and/or more maintainable, we definitely want to consider that,
> even if this changes the output slightly for some chips.
> 
Related question: When making libsensors API changes, do I update the API version
to 4.3.2, or stick with 4.3.1 ?

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-12-10 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  5:43 [lm-sensors] [PATCH v2] lm-sensors: Add support for new hwmon Guenter Roeck
2010-12-09 15:06 ` Jean Delvare
2010-12-09 15:40 ` Guenter Roeck
2010-12-09 20:31 ` Jean Delvare
2010-12-09 20:45 ` Guenter Roeck
2010-12-10 17:37 ` Guenter Roeck [this message]
2010-12-10 17:48 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101210173714.GA12627@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.