From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 12/11] omap1: Fix gpio mpuio bank to work for multi-omap for 7xx/15xx/16xx Date: Fri, 10 Dec 2010 09:41:53 -0800 Message-ID: <20101210174153.GU3054@atomide.com> References: <1290689318-10191-1-git-send-email-charu@ti.com> <20101204212554.GM17222@atomide.com> <20101207232315.GE17435@atomide.com> <201012101704.37054.jkrzyszt@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:36056 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197Ab0LJRmF (ORCPT ); Fri, 10 Dec 2010 12:42:05 -0500 Content-Disposition: inline In-Reply-To: <201012101704.37054.jkrzyszt@tis.icnet.pl> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Janusz Krzysztofik Cc: "Varadarajan, Charulatha" , Kevin Hilman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, b-cousson@ti.com, p-basak2@ti.com, Cory Maccarrone * Janusz Krzysztofik [101210 08:05]: > > We need to divide the 15xx/16xx offset by 2 for 7xx. Use bank->stride > > for that. This allows us to get rid of the duplicate defines for the > > MPUIO registers. > > > > Note that this will cause omap-keypad.c driver to not work on 7xx. > > However, the right fix there is to move over to gpio-keys instead as > > suggested by Cory Maccarrone and > > Janusz Krzysztofik . > > > > Cc: Cory Maccarrone > > Cc: Janusz Krzysztofik > > Signed-off-by: Tony Lindgren > > Acked-by: Janusz Krzysztofik Thanks, will now merge the gpio into omap-for-linus for the next merge window. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 10 Dec 2010 09:41:53 -0800 Subject: [PATCH 12/11] omap1: Fix gpio mpuio bank to work for multi-omap for 7xx/15xx/16xx In-Reply-To: <201012101704.37054.jkrzyszt@tis.icnet.pl> References: <1290689318-10191-1-git-send-email-charu@ti.com> <20101204212554.GM17222@atomide.com> <20101207232315.GE17435@atomide.com> <201012101704.37054.jkrzyszt@tis.icnet.pl> Message-ID: <20101210174153.GU3054@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Janusz Krzysztofik [101210 08:05]: > > We need to divide the 15xx/16xx offset by 2 for 7xx. Use bank->stride > > for that. This allows us to get rid of the duplicate defines for the > > MPUIO registers. > > > > Note that this will cause omap-keypad.c driver to not work on 7xx. > > However, the right fix there is to move over to gpio-keys instead as > > suggested by Cory Maccarrone and > > Janusz Krzysztofik . > > > > Cc: Cory Maccarrone > > Cc: Janusz Krzysztofik > > Signed-off-by: Tony Lindgren > > Acked-by: Janusz Krzysztofik Thanks, will now merge the gpio into omap-for-linus for the next merge window. Tony