From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC 2.6.38] ASoC: Fix bias power down of non-DAPM codec
Date: Fri, 10 Dec 2010 17:42:27 +0000 [thread overview]
Message-ID: <20101210174227.GH3200@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291998221-9642-1-git-send-email-jhnikula@gmail.com>
On Fri, Dec 10, 2010 at 06:23:41PM +0200, Jarkko Nikula wrote:
> Currently bias of non-DAPM codec will be powered down (standby/off) whenever
> there is a stream stop. This is wrong in simultaneous playback/capture since
> the bias is put down immediately after stopping the first stream.
>
> Fix this by using the codec->active count when figuring out the needed bias
> level after stream stop.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> RFC since does this look a valid fix and how to deal with 2.6.37? I think
> patching the .37 first will result in bisect build errors in mainline when
> later merging upcoming .38 changes. Would it be better to patch .37 after
> it's released?
Better to get a patch in there first, then deal with the merge up to
2.6.38. Stuff like this really does make me think we should just make
DAPM mandatory. I should have some time to look at this very soon.
next prev parent reply other threads:[~2010-12-10 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 16:23 [RFC 2.6.38] ASoC: Fix bias power down of non-DAPM codec Jarkko Nikula
2010-12-10 17:42 ` Mark Brown [this message]
2010-12-10 18:53 ` [PATCH 2.6.37] " Jarkko Nikula
2010-12-10 18:54 ` [RFC 2.6.38] ASoC: Fix build error caused by merging a fix for 2.6.37 into 2.6.38 Jarkko Nikula
2010-12-10 23:02 ` Liam Girdwood
2010-12-13 16:47 ` Mark Brown
2010-12-10 23:02 ` [PATCH 2.6.37] ASoC: Fix bias power down of non-DAPM codec Liam Girdwood
2010-12-13 16:37 ` Mark Brown
2010-12-10 21:25 ` tabs versus space fill Peter Hsiang
2010-12-10 21:35 ` Vasily Khoruzhick
2010-12-10 21:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210174227.GH3200@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.