From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Kaiser Date: Sat, 11 Dec 2010 00:41:54 +0000 Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails Message-Id: <20101211014154.3157588b@absol.kitzblitz> List-Id: References: <20101210124009.GC10623@bicker> In-Reply-To: <20101210124009.GC10623@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "David S. Miller" , Karsten Keil , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Ahem, we're printing this return value: * Dan Carpenter : > - if ((ret = copy_from_user(&size, p, sizeof(int)))) { ^^^ > + if (copy_from_user(&size, p, sizeof(int))) { > printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret); ^^^ > - return ret; > + return -EFAULT; Cheers, Nicolas Kaiser From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Kaiser Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails Date: Sat, 11 Dec 2010 01:41:54 +0100 Message-ID: <20101211014154.3157588b@absol.kitzblitz> References: <20101210124009.GC10623@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Karsten Keil , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from webhosting01.bon.m2soft.com ([195.38.20.32]:43437 "EHLO webhosting01.bon.m2soft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757321Ab0LKAnY (ORCPT ); Fri, 10 Dec 2010 19:43:24 -0500 In-Reply-To: <20101210124009.GC10623@bicker> Sender: netdev-owner@vger.kernel.org List-ID: Ahem, we're printing this return value: * Dan Carpenter : > - if ((ret = copy_from_user(&size, p, sizeof(int)))) { ^^^ > + if (copy_from_user(&size, p, sizeof(int))) { > printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret); ^^^ > - return ret; > + return -EFAULT; Cheers, Nicolas Kaiser