From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 04/16] ASoC: twl6040: Set default gains to minimun value Date: Sat, 11 Dec 2010 12:48:54 +0000 Message-ID: <20101211124854.GG9380@opensource.wolfsonmicro.com> References: <1889FA7136B567478A67D4B0F85B0CCEA4E225D3@dlee06.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 9442D24335 for ; Sat, 11 Dec 2010 13:48:43 +0100 (CET) Content-Disposition: inline In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCEA4E225D3@dlee06.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: "Olaya, Margarita" Cc: "alsa-devel@alsa-project.org" , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Fri, Dec 10, 2010 at 09:05:35PM -0600, Olaya, Margarita wrote: > From: Jorge Eduardo Candelaria > > Updated default values to improve power consumption. > > Signed-off-by: Jorge Eduardo Candelaria > Signed-off-by: Margarita Olaya Cabrera It'd be much more idiomatic to do this by having writes in the driver startup path and adding comments to explain why the defaults are being changed. Altering the table with no explanation in the code means that someone could quite easily come along later and correct the values back to the actual chip defaults, and means that someone could get surprised if they write code which assumes these are the actual chip defaults later on.