From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCHv8 00/16] boot order specification Date: Sat, 11 Dec 2010 20:02:23 +0200 Message-ID: <20101211180223.GA7994@redhat.com> References: <1291808109-22563-1-git-send-email-gleb@redhat.com> <20101211160617.GA9026@redhat.com> Reply-To: The OpenBIOS Mailinglist Mime-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: base64 Cc: anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org, kevin-BG7uPxbsK//k1uMJSBkQmQ@public.gmane.org, The OpenBIOS Mailinglist , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Blue Swirl Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbios-bounces-WyKcznhUmzJg9hUCZPvPmw@public.gmane.org Errors-To: openbios-bounces-WyKcznhUmzJg9hUCZPvPmw@public.gmane.org List-Id: kvm.vger.kernel.org T24gU2F0LCBEZWMgMTEsIDIwMTAgYXQgMDU6MTk6MDFQTSArMDAwMCwgQmx1ZSBTd2lybCB3cm90 ZToKPiA+PiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiBX aGF0IHNob3VsZCB3ZSBkbyB3aXRoCj4gPj4gYXRhLTJANjAwIHZzIGRyaXZlQDE/Cj4gPiBUaGVy ZSBpcyBubyBhdmFpbGFibGUgSURFIE9GIGJpbmRpbmcgc3BlYywgc28gSSB3aGVuIHdpdGggdGhl IHdheQo+ID4gT3BlbkJJT1MgcmVwb3J0cyBhdGEgb24gcWVtdS14ODYuIEkgaGF2ZSBubyBpZGVh IHdoYXQgNjAwIGluIGF0YS0yQDYwMAo+ID4gbWF5IG1lYW4sIGJ1dCBsb29raW5nIGF0IGczX2Jl aWdlXzMwMC5odG1sIHRoZXJlIGlzIG5vIHN1Y2ggbm9kZSB0aGVyZQo+ID4gYW5kIGxvb2tpbmcg YXQgYW55IG90aGVyIGRldmljZSB0cmVlIGluIGh0dHA6Ly9wZW5ndWlucHBjLm9yZy9oaXN0b3Jp Y2FsL2Rldi10cmVlcy1odG1sLwo+ID4gSSBoYXZlbid0IGZvdW5kIG9uZSB0aGF0IHVzZSB0aGlz IGtpbmQgb2YgYWRkcmVzc2luZyBmb3IgcGNpLWF0YS4KPiA+IGh0dHA6Ly9wZW5ndWlucHBjLm9y Zy9oaXN0b3JpY2FsL2Rldi10cmVlcy1odG1sL2czYndfNDAwLmh0bWwgZm9yCj4gPiBpbnN0YW5j ZSBoYXMgcGNpQDgwMDAwMDAwL3BjaS1icmlkZ2VAZC9wY2ktYXRhQDEvYXRhLTQuIGF0YS0yQDYw MCBraW5kIG9mCj4gPiBhZGRyZXNzaW5nIGlzIHVzZWQgYnkgZGV2aWNlcyBvbiBtYWMtaW8gYnVz IHdoaWNoIEkgZG8gbm90IHRoaW5rIHdlCj4gPiBlbXVsYXRlIGluIHFlbXUuIFNvIGl0IGxvb2tz IGxpa2UgT3BuZUJJT1MgaXMgd3JvbmcgaGVyZS4KPiAKPiBXZSBoYXZlIFBNQUMgSURFLCBidXQg dGhpcyBkZXZpY2UgaXMgQ01ENjQ2LCBzbyBtYWMtaW8gYnVzIGFkZHJlc3NpbmcKPiBydWxlcyBz aG91bGQgbm90IGJlIHVzZWQuCj4gClNvIHlvdSBhZ3JlZSB0aGF0IE9wZW5CSU9TIGlzIHdyb25n IGhlcmU/Cgo+IEluIHRoaXMgdHJlZSB0aGVyZSBhcmUgdHdvIGRpc2tzIGNvbm5lY3RlZCB0byBD TUQ2NDYsIG5hbWVkCj4gL3BjaUA4MDAwMDAwMC9wY2ktYnJpZGdlQGQvcGNpLWF0YUAxL2F0YS00 L2Rpc2sgYW5kCj4gL3BjaUA4MDAwMDAwMC9wY2ktYnJpZGdlQGQvcGNpLWF0YUAxL2F0YS00L2Rp c2tAMToKPiBodHRwOi8vcGVuZ3VpbnBwYy5vcmcvaGlzdG9yaWNhbC9kZXYtdHJlZXMtaHRtbC9n NF9wY2lfMzUwLmh0bWwKWW91IGFyZSBzYXlpbmcgdGhhdCBxZW11IGNyZWF0ZXMgcGF0aHMgbGlr ZToKL2dyYWNrbGVAZmVjMDAwMDAvaWRlQDMvZHJpdmVAMS9kaXNrQDAKL2dyYWNrbGVAZmVjMDAw MDAvaWRlQDMvZHJpdmVAMS9kaXNrQDEKCkkgZG8gbm90IHVuZGVyc3RhbmQgd2h5IHFlbXUgY3Jl YXRlcyBub2RlIGRyaXZlQDEuIEl0IHNob3VsZCBiZSBkcml2ZUAwCmFjY29yZGluZyB0byB0aGUg Y29kZS4gSSdsbCBsb29rIGF0IHdoeSB1bml0LWFkZHJlc3MgaXMgaW5jb3JyZWN0IGZvcgp0aGUg bm9kZS4gQnV0IGFzc3VtaW5nIHRoYXQgdGhpcyBwcm9ibGVtIGlzIGZpeGVkIHRoZW4gcGF0aHMg Y3JlYXRlZCBieQpxZW11IGlzIHZlcnkgc2ltaWxhciB0byB0aGUgcGF0aHMgaW4gZzRfcGNpXzM1 MC5odG1sLiBJdCBsb29rcyBsaWtlIGluIApnNF9wY2lfMzUwLmh0bWwgdGhleSBvbWl0IHVuaXQg YWRkcmVzcyBpZiBpdCBpcyB6ZXJvLgoKLS0KCQkJR2xlYi4KCi0tIApPcGVuQklPUyAgICAgICAg ICAgICAgICAgaHR0cDovL29wZW5iaW9zLm9yZy8KTWFpbGluZ2xpc3Q6ICBodHRwOi8vbGlzdHMu b3BlbmJpb3Mub3JnL21haWxtYW4vbGlzdGluZm8KRnJlZSB5b3VyIFN5c3RlbSAtIE1heSB0aGUg Rm9ydGggYmUgd2l0aCB5b3U= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44811 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PRTmA-0008LR-B3 for qemu-devel@nongnu.org; Sat, 11 Dec 2010 13:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PRTm9-0006yG-2N for qemu-devel@nongnu.org; Sat, 11 Dec 2010 13:02:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PRTm8-0006y2-Py for qemu-devel@nongnu.org; Sat, 11 Dec 2010 13:02:29 -0500 Date: Sat, 11 Dec 2010 20:02:23 +0200 From: Gleb Natapov Message-ID: <20101211180223.GA7994@redhat.com> References: <1291808109-22563-1-git-send-email-gleb@redhat.com> <20101211160617.GA9026@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Subject: [Qemu-devel] Re: [PATCHv8 00/16] boot order specification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kevin@koconnor.net, qemu-devel@nongnu.org, kvm@vger.kernel.org, The OpenBIOS Mailinglist On Sat, Dec 11, 2010 at 05:19:01PM +0000, Blue Swirl wrote: > >> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A = =9A =9A =9A =9A =9A =9A =9A What should we do with > >> ata-2@600 vs drive@1? > > There is no available IDE OF binding spec, so I when with the way > > OpenBIOS reports ata on qemu-x86. I have no idea what 600 in ata-2@600 > > may mean, but looking at g3_beige_300.html there is no such node there > > and looking at any other device tree in http://penguinppc.org/historica= l/dev-trees-html/ > > I haven't found one that use this kind of addressing for pci-ata. > > http://penguinppc.org/historical/dev-trees-html/g3bw_400.html for > > instance has pci@80000000/pci-bridge@d/pci-ata@1/ata-4. ata-2@600 kind = of > > addressing is used by devices on mac-io bus which I do not think we > > emulate in qemu. So it looks like OpneBIOS is wrong here. >=20 > We have PMAC IDE, but this device is CMD646, so mac-io bus addressing > rules should not be used. >=20 So you agree that OpenBIOS is wrong here? > In this tree there are two disks connected to CMD646, named > /pci@80000000/pci-bridge@d/pci-ata@1/ata-4/disk and > /pci@80000000/pci-bridge@d/pci-ata@1/ata-4/disk@1: > http://penguinppc.org/historical/dev-trees-html/g4_pci_350.html You are saying that qemu creates paths like: /grackle@fec00000/ide@3/drive@1/disk@0 /grackle@fec00000/ide@3/drive@1/disk@1 I do not understand why qemu creates node drive@1. It should be drive@0 according to the code. I'll look at why unit-address is incorrect for the node. But assuming that this problem is fixed then paths created by qemu is very similar to the paths in g4_pci_350.html. It looks like in=20 g4_pci_350.html they omit unit address if it is zero. -- Gleb.