From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [Qemu-devel] Re: [PATCHv8 00/16] boot order specification Date: Sat, 11 Dec 2010 21:11:26 +0200 Message-ID: <20101211191126.GA11897@redhat.com> References: <1291808109-22563-1-git-send-email-gleb@redhat.com> <20101211160617.GA9026@redhat.com> <20101211180223.GA7994@redhat.com> <20101211182752.GA11388@redhat.com> Reply-To: The OpenBIOS Mailinglist Mime-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: base64 Cc: The OpenBIOS Mailinglist , kevin-BG7uPxbsK//k1uMJSBkQmQ@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Blue Swirl Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbios-bounces-WyKcznhUmzJg9hUCZPvPmw@public.gmane.org Errors-To: openbios-bounces-WyKcznhUmzJg9hUCZPvPmw@public.gmane.org List-Id: kvm.vger.kernel.org T24gU2F0LCBEZWMgMTEsIDIwMTAgYXQgMDc6MDY6MDRQTSArMDAwMCwgQmx1ZSBTd2lybCB3cm90 ZToKPiAyMDEwLzEyLzExIEdsZWIgTmF0YXBvdiA8Z2xlYkByZWRoYXQuY29tPjoKPiA+IE9uIFNh dCwgRGVjIDExLCAyMDEwIGF0IDA4OjAyOjIzUE0gKzAyMDAsIEdsZWIgTmF0YXBvdiB3cm90ZToK PiA+PiBPbiBTYXQsIERlYyAxMSwgMjAxMCBhdCAwNToxOTowMVBNICswMDAwLCBCbHVlIFN3aXJs IHdyb3RlOgo+ID4+ID4gPj4gmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCaIJogmiCa IJogmiCaIJogV2hhdCBzaG91bGQgd2UgZG8gd2l0aAo+ID4+ID4gPj4gYXRhLTJANjAwIHZzIGRy aXZlQDE/Cj4gPj4gPiA+IFRoZXJlIGlzIG5vIGF2YWlsYWJsZSBJREUgT0YgYmluZGluZyBzcGVj LCBzbyBJIHdoZW4gd2l0aCB0aGUgd2F5Cj4gPj4gPiA+IE9wZW5CSU9TIHJlcG9ydHMgYXRhIG9u IHFlbXUteDg2LiBJIGhhdmUgbm8gaWRlYSB3aGF0IDYwMCBpbiBhdGEtMkA2MDAKPiA+PiA+ID4g bWF5IG1lYW4sIGJ1dCBsb29raW5nIGF0IGczX2JlaWdlXzMwMC5odG1sIHRoZXJlIGlzIG5vIHN1 Y2ggbm9kZSB0aGVyZQo+ID4+ID4gPiBhbmQgbG9va2luZyBhdCBhbnkgb3RoZXIgZGV2aWNlIHRy ZWUgaW4gaHR0cDovL3Blbmd1aW5wcGMub3JnL2hpc3RvcmljYWwvZGV2LXRyZWVzLWh0bWwvCj4g Pj4gPiA+IEkgaGF2ZW4ndCBmb3VuZCBvbmUgdGhhdCB1c2UgdGhpcyBraW5kIG9mIGFkZHJlc3Np bmcgZm9yIHBjaS1hdGEuCj4gPj4gPiA+IGh0dHA6Ly9wZW5ndWlucHBjLm9yZy9oaXN0b3JpY2Fs L2Rldi10cmVlcy1odG1sL2czYndfNDAwLmh0bWwgZm9yCj4gPj4gPiA+IGluc3RhbmNlIGhhcyBw Y2lAODAwMDAwMDAvcGNpLWJyaWRnZUBkL3BjaS1hdGFAMS9hdGEtNC4gYXRhLTJANjAwIGtpbmQg b2YKPiA+PiA+ID4gYWRkcmVzc2luZyBpcyB1c2VkIGJ5IGRldmljZXMgb24gbWFjLWlvIGJ1cyB3 aGljaCBJIGRvIG5vdCB0aGluayB3ZQo+ID4+ID4gPiBlbXVsYXRlIGluIHFlbXUuIFNvIGl0IGxv b2tzIGxpa2UgT3BuZUJJT1MgaXMgd3JvbmcgaGVyZS4KPiA+PiA+Cj4gPj4gPiBXZSBoYXZlIFBN QUMgSURFLCBidXQgdGhpcyBkZXZpY2UgaXMgQ01ENjQ2LCBzbyBtYWMtaW8gYnVzIGFkZHJlc3Np bmcKPiA+PiA+IHJ1bGVzIHNob3VsZCBub3QgYmUgdXNlZC4KPiA+PiA+Cj4gPj4gU28geW91IGFn cmVlIHRoYXQgT3BlbkJJT1MgaXMgd3JvbmcgaGVyZT8KPiA+Pgo+ID4+ID4gSW4gdGhpcyB0cmVl IHRoZXJlIGFyZSB0d28gZGlza3MgY29ubmVjdGVkIHRvIENNRDY0NiwgbmFtZWQKPiA+PiA+IC9w Y2lAODAwMDAwMDAvcGNpLWJyaWRnZUBkL3BjaS1hdGFAMS9hdGEtNC9kaXNrIGFuZAo+ID4+ID4g L3BjaUA4MDAwMDAwMC9wY2ktYnJpZGdlQGQvcGNpLWF0YUAxL2F0YS00L2Rpc2tAMToKPiA+PiA+ IGh0dHA6Ly9wZW5ndWlucHBjLm9yZy9oaXN0b3JpY2FsL2Rldi10cmVlcy1odG1sL2c0X3BjaV8z NTAuaHRtbAo+ID4+IFlvdSBhcmUgc2F5aW5nIHRoYXQgcWVtdSBjcmVhdGVzIHBhdGhzIGxpa2U6 Cj4gPj4gL2dyYWNrbGVAZmVjMDAwMDAvaWRlQDMvZHJpdmVAMS9kaXNrQDAKPiA+PiAvZ3JhY2ts ZUBmZWMwMDAwMC9pZGVAMy9kcml2ZUAxL2Rpc2tAMQo+ID4+Cj4gPj4gSSBkbyBub3QgdW5kZXJz dGFuZCB3aHkgcWVtdSBjcmVhdGVzIG5vZGUgZHJpdmVAMS4gSXQgc2hvdWxkIGJlIGRyaXZlQDAK PiA+PiBhY2NvcmRpbmcgdG8gdGhlIGNvZGUuIEknbGwgbG9vayBhdCB3aHkgdW5pdC1hZGRyZXNz IGlzIGluY29ycmVjdCBmb3IKPiA+PiB0aGUgbm9kZS4gQnV0IGFzc3VtaW5nIHRoYXQgdGhpcyBw cm9ibGVtIGlzIGZpeGVkIHRoZW4gcGF0aHMgY3JlYXRlZCBieQo+ID4+IHFlbXUgaXMgdmVyeSBz aW1pbGFyIHRvIHRoZSBwYXRocyBpbiBnNF9wY2lfMzUwLmh0bWwuIEl0IGxvb2tzIGxpa2UgaW4K PiA+PiBnNF9wY2lfMzUwLmh0bWwgdGhleSBvbWl0IHVuaXQgYWRkcmVzcyBpZiBpdCBpcyB6ZXJv Lgo+ID4+Cj4gPiBBaCB0aGUgcHJvYmxlbSBpcyB0aGF0IHdlIGhhdmUgbm90IHFkZXZpZmllZCBt YWMgaW8gYnVzLiBTaW5jZSBmaXJzdCB0bwo+ID4gaWRlIGRpc2tzIGFyZSBhdXRvbWF0aWNhbGx5 IGF0dGFjaGVkIHRvIG1hYy1pbyBidXMgZGV2aWNlIHBhdGhzIGZvciB0aGVtCj4gPiBhcmUgaW5j b3JyZWN0LiBOZXh0IHR3byBpZGUgZGV2aWNlcyB3aWxsIGJlIGF0dGFjaGVkIHRvIENNRDY0NiBh bmQgcWVtdQo+ID4gd2lsbCBnZW5lcmF0ZSBjb3JyZWN0IGRldmljZSBwYXRocyBmb3IgdGhlbToK PiA+Cj4gPiBxZW11LXN5c3RlbS1wcGMgLWRyaXZlIGlmPW5vbmUsaWQ9aGRhLGZpbGU9L2Rldi9u dWxsIC1kZXZpY2UgaWRlLWRyaXZlLGRyaXZlPWhkYSxib290aW5kZXg9MQo+ID4gLWRyaXZlIGlm PW5vbmUsaWQ9Y2QsZmlsZT0vZGV2L251bGwgLWRldmljZSBpZGUtZHJpdmUsZHJpdmU9Y2QsYm9v dGluZGV4PTAgLW5vZ3JhcGhpYyAtZHJpdmUKPiA+IGlmPW5vbmUsaWQ9aGRiLGZpbGU9L2Rldi9u dWxsIC1kZXZpY2UgaWRlLWRyaXZlLGRyaXZlPWhkYixidXM9aWRlLjAsYm9vdGluZGV4PTIgLWRy aXZlCj4gPiBpZj1ub25lLGlkPWhkYyxmaWxlPS9kZXYvbnVsbCAtZGV2aWNlIGlkZS1kcml2ZSxk cml2ZT1oZGMsYnVzPWlkZS4wLGJvb3RpbmRleD0zCj4gPiBhZGRpbmcgJy9ncmFja2xlQGZlYzAw MDAwL2lkZUAzL2RyaXZlQDEvZGlza0AxJyBhdCBpbmRleCAwCj4gPiBhZGRpbmcgJy9ncmFja2xl QGZlYzAwMDAwL2lkZUAzL2RyaXZlQDEvZGlza0AwJyBhdCBpbmRleCAxCj4gPiBhZGRpbmcgJy9n cmFja2xlQGZlYzAwMDAwL2lkZUAzL2RyaXZlQDAvZGlza0AwJyBhdCBpbmRleCAyCj4gPiBhZGRp bmcgJy9ncmFja2xlQGZlYzAwMDAwL2lkZUAzL2RyaXZlQDAvZGlza0AxJyBhdCBpbmRleCAzCj4g Cj4gQnV0IHdoeSBpcyB0aGUgcGF0aCBhbG1vc3QgdGhlIHNhbWUgYXMgQ01ENjQ2LCBzaG91bGRu J3QgJ2lkZUAzJyBiZQo+IGRpZmZlcmVudCBzaW5jZSB0aGUgUENJIGRldmljZSBpcyBub3QgdGhl IHNhbWU/Cj4KSXQgc2hvdWxkLCBidXQgc2luY2UgdGhlIG1hYyBpbyBpcyBub3QgcWRldmlmaWVk IHRoZXJlIGlzIG5vIHFkZXYgcGNpCmRldmljZSBmb3IgaXQuCiAKPiA+IFNvIHRoZSBmaXggaXMg dG8gcWRldmlmeSBtYWMgaW8gYnVzLgo+IAo+IE9LLgoKLS0KCQkJR2xlYi4KCi0tIApPcGVuQklP UyAgICAgICAgICAgICAgICAgaHR0cDovL29wZW5iaW9zLm9yZy8KTWFpbGluZ2xpc3Q6ICBodHRw Oi8vbGlzdHMub3BlbmJpb3Mub3JnL21haWxtYW4vbGlzdGluZm8KRnJlZSB5b3VyIFN5c3RlbSAt IE1heSB0aGUgRm9ydGggYmUgd2l0aCB5b3U= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55607 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PRUrN-0003wv-Av for qemu-devel@nongnu.org; Sat, 11 Dec 2010 14:12:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PRUqx-0007x6-Tz for qemu-devel@nongnu.org; Sat, 11 Dec 2010 14:11:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PRUqx-0007wg-MU for qemu-devel@nongnu.org; Sat, 11 Dec 2010 14:11:31 -0500 Date: Sat, 11 Dec 2010 21:11:26 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] Re: [PATCHv8 00/16] boot order specification Message-ID: <20101211191126.GA11897@redhat.com> References: <1291808109-22563-1-git-send-email-gleb@redhat.com> <20101211160617.GA9026@redhat.com> <20101211180223.GA7994@redhat.com> <20101211182752.GA11388@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: The OpenBIOS Mailinglist , kevin@koconnor.net, qemu-devel@nongnu.org, kvm@vger.kernel.org On Sat, Dec 11, 2010 at 07:06:04PM +0000, Blue Swirl wrote: > 2010/12/11 Gleb Natapov : > > On Sat, Dec 11, 2010 at 08:02:23PM +0200, Gleb Natapov wrote: > >> On Sat, Dec 11, 2010 at 05:19:01PM +0000, Blue Swirl wrote: > >> > >> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A = =9A =9A =9A =9A =9A =9A =9A =9A What should we do with > >> > >> ata-2@600 vs drive@1? > >> > > There is no available IDE OF binding spec, so I when with the way > >> > > OpenBIOS reports ata on qemu-x86. I have no idea what 600 in ata-2= @600 > >> > > may mean, but looking at g3_beige_300.html there is no such node t= here > >> > > and looking at any other device tree in http://penguinppc.org/hist= orical/dev-trees-html/ > >> > > I haven't found one that use this kind of addressing for pci-ata. > >> > > http://penguinppc.org/historical/dev-trees-html/g3bw_400.html for > >> > > instance has pci@80000000/pci-bridge@d/pci-ata@1/ata-4. ata-2@600 = kind of > >> > > addressing is used by devices on mac-io bus which I do not think we > >> > > emulate in qemu. So it looks like OpneBIOS is wrong here. > >> > > >> > We have PMAC IDE, but this device is CMD646, so mac-io bus addressing > >> > rules should not be used. > >> > > >> So you agree that OpenBIOS is wrong here? > >> > >> > In this tree there are two disks connected to CMD646, named > >> > /pci@80000000/pci-bridge@d/pci-ata@1/ata-4/disk and > >> > /pci@80000000/pci-bridge@d/pci-ata@1/ata-4/disk@1: > >> > http://penguinppc.org/historical/dev-trees-html/g4_pci_350.html > >> You are saying that qemu creates paths like: > >> /grackle@fec00000/ide@3/drive@1/disk@0 > >> /grackle@fec00000/ide@3/drive@1/disk@1 > >> > >> I do not understand why qemu creates node drive@1. It should be drive@0 > >> according to the code. I'll look at why unit-address is incorrect for > >> the node. But assuming that this problem is fixed then paths created by > >> qemu is very similar to the paths in g4_pci_350.html. It looks like in > >> g4_pci_350.html they omit unit address if it is zero. > >> > > Ah the problem is that we have not qdevified mac io bus. Since first to > > ide disks are automatically attached to mac-io bus device paths for them > > are incorrect. Next two ide devices will be attached to CMD646 and qemu > > will generate correct device paths for them: > > > > qemu-system-ppc -drive if=3Dnone,id=3Dhda,file=3D/dev/null -device ide-= drive,drive=3Dhda,bootindex=3D1 > > -drive if=3Dnone,id=3Dcd,file=3D/dev/null -device ide-drive,drive=3Dcd,= bootindex=3D0 -nographic -drive > > if=3Dnone,id=3Dhdb,file=3D/dev/null -device ide-drive,drive=3Dhdb,bus= =3Dide.0,bootindex=3D2 -drive > > if=3Dnone,id=3Dhdc,file=3D/dev/null -device ide-drive,drive=3Dhdc,bus= =3Dide.0,bootindex=3D3 > > adding '/grackle@fec00000/ide@3/drive@1/disk@1' at index 0 > > adding '/grackle@fec00000/ide@3/drive@1/disk@0' at index 1 > > adding '/grackle@fec00000/ide@3/drive@0/disk@0' at index 2 > > adding '/grackle@fec00000/ide@3/drive@0/disk@1' at index 3 >=20 > But why is the path almost the same as CMD646, shouldn't 'ide@3' be > different since the PCI device is not the same? > It should, but since the mac io is not qdevified there is no qdev pci device for it. =20 > > So the fix is to qdevify mac io bus. >=20 > OK. -- Gleb.