From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver. Date: Sat, 11 Dec 2010 19:23:20 +0000 Message-ID: <20101211192320.GA24430@void.printf.net> References: <20101208115510.GD10998@console-pimps.org> <20101209064751.GA21128@void.printf.net> <20101209160157.GA28586@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Will Newton Cc: Matt Fleming , linux-mmc@vger.kernel.org, Linux Kernel list , linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org SGkgV2lsbCwKCk9uIFRodSwgRGVjIDA5LCAyMDEwIGF0IDA1OjI0OjI2UE0gKzAwMDAsIFdpbGwg TmV3dG9uIHdyb3RlOgo+IFRoaXMgYWRkcyB0aGUgbW1jIGhvc3QgZHJpdmVyIGZvciB0aGUgU3lu b3BzeXMgRGVzaWduV2FyZSBtbWMKPiBob3N0IGNvbnRyb2xsZXIsIGZvdW5kIGluIGEgbnVtYmVy IG9mIGVtYmVkZGVkIFNvQyBkZXNpZ25zLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFdpbGwgTmV3dG9u IDx3aWxsLm5ld3RvbkBpbWd0ZWMuY29tPgo+IFJldmlld2VkLWJ5OiBNYXR0IEZsZW1pbmcgPG1h dHRAY29uc29sZS1waW1wcy5vcmc+CgpSdW5uaW5nIGEgdGVzdCBidWlsZCBvbiBBUk0gZmFpbHM6 Cgpkcml2ZXJzL21tYy9ob3N0L2R3X21tYy5jOiBJbiBmdW5jdGlvbiDigJhkd19tY2lfcHVzaF9k YXRhNjTigJk6CmRyaXZlcnMvbW1jL2hvc3QvZHdfbW1jLmM6OTg1OiBlcnJvcjogaW1wbGljaXQg ZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYX19yYXdfd3JpdGVx4oCZCmRyaXZlcnMvbW1jL2hv c3QvZHdfbW1jLmM6IEluIGZ1bmN0aW9uIOKAmGR3X21jaV9wdWxsX2RhdGE2NOKAmToKZHJpdmVy cy9tbWMvaG9zdC9kd19tbWMuYzo5OTg6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBm dW5jdGlvbiDigJhfX3Jhd19yZWFkceKAmQoKYmVjYXVzZSBhcmNoL2FybSBkb2Vzbid0IGltcGxl bWVudCByYXcgdmVyc2lvbnMgb2YgdGhlc2UgNjQtYml0IGFjY2Vzc2VzLgpJJ20gc3VycHJpc2Vk IHRoYXQgdGhpcyBkcml2ZXIgaGFzbid0IGJlZW4gY29tcGlsZWQgb24gQVJNIGJlZm9yZSEgIFdo YXQKa2luZCBvZiBhcmNoIGFyZSB5b3UgdGVzdGluZyBvbj8gIERvIHlvdSBoYXZlIGFueSBBUk0g aGFyZHdhcmUgKGxwYzMxM3g/KQp0byB2ZXJpZnkgdGhlIGRyaXZlciBvbj8KClRoYW5rcywKCi0t IApDaHJpcyBCYWxsICAgPGNqYkBsYXB0b3Aub3JnPiAgIDxodHRwOi8vcHJpbnRmLm5ldC8+Ck9u ZSBMYXB0b3AgUGVyIENoaWxkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: cjb@laptop.org (Chris Ball) Date: Sat, 11 Dec 2010 19:23:20 +0000 Subject: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver. In-Reply-To: References: <20101208115510.GD10998@console-pimps.org> <20101209064751.GA21128@void.printf.net> <20101209160157.GA28586@void.printf.net> Message-ID: <20101211192320.GA24430@void.printf.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Will, On Thu, Dec 09, 2010 at 05:24:26PM +0000, Will Newton wrote: > This adds the mmc host driver for the Synopsys DesignWare mmc > host controller, found in a number of embedded SoC designs. > > Signed-off-by: Will Newton > Reviewed-by: Matt Fleming Running a test build on ARM fails: drivers/mmc/host/dw_mmc.c: In function ?dw_mci_push_data64?: drivers/mmc/host/dw_mmc.c:985: error: implicit declaration of function ?__raw_writeq? drivers/mmc/host/dw_mmc.c: In function ?dw_mci_pull_data64?: drivers/mmc/host/dw_mmc.c:998: error: implicit declaration of function ?__raw_readq? because arch/arm doesn't implement raw versions of these 64-bit accesses. I'm surprised that this driver hasn't been compiled on ARM before! What kind of arch are you testing on? Do you have any ARM hardware (lpc313x?) to verify the driver on? Thanks, -- Chris Ball One Laptop Per Child