All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Berra <bluca@comedia.it>
To: linux-raid@vger.kernel.org
Subject: [PATCH] segfault in imsm create with wrong arguments
Date: Sun, 12 Dec 2010 12:33:55 +0100	[thread overview]
Message-ID: <20101212113355.GA24577@maude.comedia.it> (raw)

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

-- 
Luca Berra -- bluca@comedia.it

[-- Attachment #2: mdadm-3.1.4-imsm-create-segfault.patch --]
[-- Type: text/plain, Size: 639 bytes --]

When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

Signed-off-by: Luca Berra <bluca@comedia.it>

diff -p -up mdadm-3.1.4/super-intel.c.bluca mdadm-3.1.4/super-intel.c
--- mdadm-3.1.4/super-intel.c.bluca	2010-08-26 02:24:16.000000000 +0000
+++ mdadm-3.1.4/super-intel.c	2010-12-12 11:13:00.024371004 +0000
@@ -4119,7 +4119,7 @@ static int default_chunk_imsm(struct sup
 {
 	struct intel_super *super = st->sb;
 
-	if (!super->orom)
+	if (!super || !super->orom)
 		return 0;
 
 	return imsm_orom_default_chunk(super->orom);

             reply	other threads:[~2010-12-12 11:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-12 11:33 Luca Berra [this message]
2010-12-13  2:51 ` [PATCH] segfault in imsm create with wrong arguments Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101212113355.GA24577@maude.comedia.it \
    --to=bluca@comedia.it \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.