Re: [Qemu-devel] [PATCH 0/6] usb-ccid (v8)

[Alon Levy <alevy@redhat.com>]

On Sat, Dec 11, 2010 at 03:55:10PM +0000, Blue Swirl wrote:
> On Sat, Dec 11, 2010 at 3:33 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > Hi,
> >
> > On 12/11/2010 10:43 AM, Blue Swirl wrote:
> >>
> >> On Tue, Dec 7, 2010 at 10:20 AM, Alon Levy<alevy@redhat.com>  wrote:
> >>>
> >>> ping.
> >>
> >> I don't think Anthony's concerns (or mine) have been addressed.
> >>
> >
> > Could you be a bit more verbose please ?
> 
> I'm not sure if this answer was OK for Anthony given the previous discussion:
> http://article.gmane.org/gmane.comp.emulators.qemu/85793
> 

I'm pretty sure it's ok by anthony since he suggested the inclusion of
libcacard in qemu in the first place. (that's not a typo - I've renamed
it to avoid the double card, I'll send an updated patch merging 4/6 and
including this rename).

> About my concerns, see my previous mail about merging the shared
> library fix to 4/6 and about other stuff that does not belong to QEMU
> but which should be a separate project.
> 
your concerns were:
 usb-ccid.c:
  endianess - I've added network to host convertions (used as guest to host).
  coding style - answer_t and bulk_in_t renamed
  hungarian style usage - gave 'excuse' (spec uses those names)
  anonymous structs usage - named
 libcaccard:
  don't build a library that qemu doesn't use: v8.1, will fold in and send v9

Am I missing anything?

Alon