Re: [PATCH 0/2] perf tools: add reference timestamp and use it in time history dump

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Dec 09, 2010 at 03:18:53PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 07, 2010 at 06:54:43PM -0700, David Ahern escreveu:
> > David Ahern (2):
> >   perf tools: Add reference timestamp to perf header
> >   perf tools: Add option to show time history of event samples
> > 
> >  tools/perf/builtin-record.c |    8 +++
> >  tools/perf/builtin-report.c |  131 ++++++++++++++++++++++++++++++++++++++++++-
> >  tools/perf/util/header.c    |   51 +++++++++++++++++
> >  tools/perf/util/header.h    |    3 +
> >  tools/perf/util/session.c   |   26 +++++++++
> >  5 files changed, 217 insertions(+), 2 deletions(-)
> 
> I'll go to a business trip today/tomorrow, will try to check these while
> at the hotel.
> 
> Frederic, if you have some time, could you take a look? I touches the
> HEADER_FEAT stuff, the feature has a huge potential, merging app
> specific logs with perf report output helps correlating counter to app
> specific events, great stuff.
> 
> I would just love to have at least one more person reviewing this,
> thanks,


It looks mostly ok, except few nits I noticed.

Thanks!